#4894 - setAmbientTemperatureSchedule and setAmbientAirVelocitySchedule setter for PipeIndoor do not work
#4901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unknown file: Failure C++ exception with description "/Users/julien/Software/Others/OpenStudio/src/model/ScheduleTypeRegistry.cpp@68 : No 'Ambient Temperature Schedule' Schedule is registered for class PipeIndoor." thrown in the test body.
jmarrec
added
severity - Minor Bug
component - HVAC
component - Model
Pull Request - Ready for CI
jmarrec
commented
May 31, 2023
Comment on lines
+80
to
+82
| EXPECT_TRUE(pipeIndoor.setAmbientTemperatureSchedule(ambientTemperatureSchedule)); | ||
| ASSERT_TRUE(pipeIndoor.ambientTemperatureSchedule()); | ||
| EXPECT_EQ(ambientTemperatureSchedule, pipeIndoor.ambientTemperatureSchedule().get()); |
There was a problem hiding this comment.
Without fix:
[ RUN ] ModelFixture.PipeIndoor_GettersSetters
unknown file: Failure
C++ exception with description "/Users/julien/Software/Others/OpenStudio/src/model/ScheduleTypeRegistry.cpp@68 : No 'Ambient Temperature Schedule' Schedule is registered for class PipeIndoor." thrown in the test body.
[ FAILED ] ModelFixture.PipeIndoor_GettersSetters (4 ms)
Comment on lines
+343
to
+344
| {"PipeIndoor", "Ambient Temperature Schedule", "ambientTemperatureSchedule", true, "Temperature", OptionalDouble(), OptionalDouble()}, | ||
| {"PipeIndoor", "Ambient Air Velocity Schedule", "ambientAirVelocitySchedule", true, "Velocity", 0.0, OptionalDouble()}, |
There was a problem hiding this comment.
Actual fix for #4894
|
CI Results for a5df3ae:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
setAmbientTemperatureScheduleandsetAmbientAirVelocitySchedulesetter forPipeIndoordo not work #4894Pull Request Author
src/model/test)src/energyplus/Test)src/osversion/VersionTranslator.cpp)Labels:
IDDChangeAPIChangePull Request - Ready for CIso that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.