Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to EnergyPlus v23.2.0 official #4989

Merged
merged 3 commits into from Sep 29, 2023
Merged

Update to EnergyPlus v23.2.0 official #4989

merged 3 commits into from Sep 29, 2023

Conversation

jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented Sep 29, 2023

Pull request overview

Update to E+ v23.1.0 official (after building 22.04 arm64, mac arm64, and Centos7 and uploading them to the E+ release)

The Win32 build is missing right now, we'll need to update the CMakeLists.txt one last time when it's up on the release page.

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@jmarrec jmarrec added component - IDF Translation Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. labels Sep 29, 2023
@jmarrec jmarrec self-assigned this Sep 29, 2023
@ci-commercialbuildings
Copy link
Collaborator

ci-commercialbuildings commented Sep 29, 2023

CI Results for c012313:

@jmarrec jmarrec merged commit 308fa5a into develop Sep 29, 2023
3 of 6 checks passed
@jmarrec jmarrec deleted the v23.2.0-official branch September 29, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component - IDF Translation Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants