Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate regression tests failures #4977

Closed
jmarrec opened this issue Sep 20, 2023 · 6 comments · Fixed by #4988
Closed

Investigate regression tests failures #4977

jmarrec opened this issue Sep 20, 2023 · 6 comments · Fixed by #4988

Comments

@jmarrec
Copy link
Collaborator

jmarrec commented Sep 20, 2023

Issue overview

I ran with develop and with the tip of V23-2-0IOFreeze branch. Some failures on develop, more failures on IOFreeze

image

Possible Solution

Investigate and adjust SDK and/or test

Details

Environment

Some additional details about your environment for this issue (if relevant):

  • Platform (Operating system, version):
  • Version of OpenStudio (if using an intermediate build, include SHA):

Context

@jmarrec
Copy link
Collaborator Author

jmarrec commented Sep 20, 2023

4 way comparison, % change compared to 3.6.1 usage

image

Definitely an issue with the Unitary system:

@jmarrec jmarrec added this to the OpenStudio SDK 3.7.0 milestone Sep 20, 2023
@jmarrec jmarrec changed the title Investigate regression tests failurs Investigate regression tests failures Sep 22, 2023
@jmarrec
Copy link
Collaborator Author

jmarrec commented Sep 28, 2023

image

@jmarrec
Copy link
Collaborator Author

jmarrec commented Sep 28, 2023

Test Type Cause Status
fan_systemmodel osm E+ segfault NREL/EnergyPlus#10251
fan_systemmodel rb E+ segfault NREL/EnergyPlus#10251
ghx_horizontal_trench_kusuda osm LoadProfile:Plant VT missing Fixed in 28252a8
ghx_horizontal_trench_xing osm LoadProfile:Plant VT missing Fixed in 28252a8
heatpump_plantloop_eir osm HeatPump:PlantLoop:EIR:* VT missing Fixed in bad90b7
ideal_plant osm LoadProfile:Plant VT missing Fixed in 28252a8
unitary_vav_bypass_coiltypes osm Equipment Placement NREL/EnergyPlus#10254
unitary_vav_bypass_coiltypes rb Equipment Placement NREL/EnergyPlus#10254

For unitary_vav_bypass_coiltypes, nothing in the IDF has changed, but the eplusout.err now contains:

   ** Severe  ** AirLoopHVAC:UnitaryHeatCool:VAVChangeoverBypass: AIR LOOP HVAC UNITARY HEAT COOL VAVCHANGEOVER BYPASS 3
   **   ~~~   ** Illegal cooling coil placement. The cooling coil inlet node name must be the same as the mixed air node specified in the Outdoor Air Mixer Name = AIR LOOP HVAC UNITARY HEAT COOL VAVCHANGEOVER BYPASS 3 OUTDOOR AIR MIXER when draw through Supply Air Fan Placement is selected.
   **  Fatal  ** GetCBVAV: Errors found in getting AirLoopHVAC:UnitaryHeatCool:VAVChangeoverBypass input.

jmarrec added a commit that referenced this issue Sep 29, 2023
Fix #4977 - Address regression tests failures
@jmarrec jmarrec reopened this Sep 29, 2023
@jmarrec
Copy link
Collaborator Author

jmarrec commented Sep 29, 2023

Reopening until I confirm that with E+ 23.2.0 official there are no more unintended failures.

@jmarrec
Copy link
Collaborator Author

jmarrec commented Sep 29, 2023

All good with 23.2.0 official and the recent fixes. #4989

image

@jmarrec
Copy link
Collaborator Author

jmarrec commented Sep 29, 2023

Closed via #4989

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant