Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5167 - measure.xml default bool values reported as 0/1 on develop #5168

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented Apr 25, 2024

Pull request overview

Tested locally by adding a new bool argument with a default value of true in a measure and running the update before/after fix

Ideally I'd add an automated test but this is likely going to take me 2 hours which I don't have

image

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@jmarrec jmarrec added component - Measures Developer Issue Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. labels Apr 25, 2024
@jmarrec jmarrec requested a review from shorowit April 25, 2024 07:30
@jmarrec jmarrec self-assigned this Apr 25, 2024
@ci-commercialbuildings
Copy link
Collaborator

ci-commercialbuildings commented Apr 25, 2024

CI Results for f5fe157:

@jmarrec jmarrec merged commit bce4511 into develop Apr 25, 2024
2 of 6 checks passed
@jmarrec jmarrec deleted the 5167_boolalpha branch April 25, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component - Measures Developer Issue Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

measure.xml default bool values reported as 0/1 on develop
2 participants