Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

measure.xml default bool values reported as 0/1 on develop #5167

Closed
jmarrec opened this issue Apr 25, 2024 · 0 comments · Fixed by #5168
Closed

measure.xml default bool values reported as 0/1 on develop #5167

jmarrec opened this issue Apr 25, 2024 · 0 comments · Fixed by #5168
Assignees
@jmarrec
Labels
component - Measures Developer Issue severity - Normal Bug

Comments

@jmarrec
Copy link
Collaborator

jmarrec commented Apr 25, 2024

Issue overview

@shorowit reported

I recently updated an OS measure using this build from 5 days ago and it changed all the boolean default values in the measure.xml from false/true to 0/1. (edited)

Current Behavior

it's now 0/1

Expected Behavior

Should be true, not 1.

Steps to Reproduce

Possible Solution

I removed the std::boolapha in https://github.com/NREL/OpenStudio/pull/5142/files#diff-1ce00edad4729733f34a2d1711e926e7d1d09f6ff94bae92e201b7ca3bcef23fR969

Details

Environment

Some additional details about your environment for this issue (if relevant):

  • Platform (Operating system, version): all
  • Version of OpenStudio (if using an intermediate build, include SHA): 276859d

Context
@jmarrec jmarrec added the Triage Issue needs to be assessed and labeled, further information on reported might be needed label Apr 25, 2024
jmarrec added a commit that referenced this issue Apr 25, 2024
@jmarrec
Fix #5167
f5fe157
@jmarrec jmarrec mentioned this issue Apr 25, 2024
Merged
19 tasks
@jmarrec jmarrec added severity - Normal Bug component - Measures Developer Issue and removed Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Apr 25, 2024
@jmarrec jmarrec self-assigned this Apr 25, 2024
jmarrec added a commit that referenced this issue Apr 25, 2024
@jmarrec
Fix #5167
fcaaea8
jmarrec added a commit that referenced this issue Apr 25, 2024
@jmarrec
Fix #5167
e7fb16b
jmarrec added a commit that referenced this issue Apr 25, 2024
@jmarrec
Merge pull request #5168 from NREL/5167_boolalpha
bce4511 
Fix #5167 - measure.xml default bool values reported as 0/1 on develop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmarrec jmarrec

Labels
component - Measures Developer Issue severity - Normal Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #5167 - measure.xml default bool values reported as 0/1 on develop NREL/OpenStudio
1 participant
@jmarrec