Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect EASIUR health costs #254

Closed
adfarth opened this issue Aug 23, 2023 · 0 comments · Fixed by #255
Closed

Fix incorrect EASIUR health costs #254

adfarth opened this issue Aug 23, 2023 · 0 comments · Fixed by #255
Milestone
v1.0.0 release

Comments

@adfarth
Copy link
Collaborator

adfarth commented Aug 23, 2023 •
edited
Loading

Calculations of EASIUR health costs are currently incorrect (do not align with v2 and EASIUR website). We should also add a test to catch this in the future.

I believe the issue is happening in the setindex! functions:

REopt.jl/src/core/financial.jl

Line 408 in 9c46f8a

setindex!(ret_map, v .* (v.^(pop_year - 2005)), k)
and
@adfarth adfarth added this to the v1.0.0 release milestone Aug 23, 2023
@adfarth adfarth linked a pull request Aug 23, 2023 that will close this issue
Easiur fix #255
Merged
@adfarth adfarth closed this as completed Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0 release
Development

Successfully merging a pull request may close this issue.

Easiur fix NREL/REopt.jl
1 participant
@adfarth