Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor changes and additions to outputs v3, bug fix v2 #196

Merged
merged 9 commits into from
Mar 15, 2023
Merged

Minor changes and additions to outputs v3, bug fix v2 #196

merged 9 commits into from
Mar 15, 2023

Conversation

adfarth
Copy link
Collaborator

@adfarth adfarth commented Mar 9, 2023 •
edited

Minor name change and addition of missing BAU outputs.

Changed

  • Financial breakeven_cost_of_emissions_reduction_per_tonnes_CO2 to breakeven_cost_of_emissions_reduction_per_tonne_CO2

Added

  • Previously missing Financial BAU outputs: lifecycle_om_costs_before_tax, lifecycle_om_costs_after_tax, year_one_om_costs_before_tax

Fixed

  • Fixed if statement to determing ElectricLoad "year" from && to ||, so that defaults to 2017 if any CRB input is used

@adfarth adfarth added this to the v1.0.0 release milestone Mar 9, 2023
@adfarth adfarth mentioned this pull request Mar 9, 2023
Merged
1 task
@adfarth adfarth changed the title Inputs outputs Minor changes and additions to outputs v3, bug fix v2 Mar 9, 2023
@adfarth adfarth marked this pull request as ready for review March 10, 2023 16:12
@adfarth adfarth requested a review from rathod-b March 10, 2023 16:19
@adfarth adfarth merged commit 9a922a8 into develop Mar 15, 2023
@adfarth adfarth deleted the inputs-outputs branch March 15, 2023 18:51
@adfarth adfarth mentioned this pull request Mar 16, 2023
Merged
rathod-b pushed a commit that referenced this pull request Mar 8, 2024
@adfarth
Merge pull request #196 from NREL/inputs-outputs
a7b56a9 
Minor changes and additions to outputs v3, bug fix v2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rathod-b rathod-b rathod-b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0 release
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adfarth @rathod-b