v0.41.0 master < develop #357

adfarth · 2024-03-08T23:14:36Z

using Cambium instead of AVERT for CO2 emissions by default

Based on Cambium 2022 Mid-Case Scenario, LRMER CO2e (Combustion+Precombustion) 2024-2049 values

no longer an output under Site

under ElectricUtility

end use or busbar

This will prevent a Cambium API call with each unit test

For tests: - changed "region_abbreviation" to "avert_region_abbreviation" - Updated RE and Emissions expected values to account for alignment between load year and emissions year (tested with assumed AVERT emissions year of 2017 to ensure that this is why the emissions values changed) - Added 0 grid emissions to scenario.jl when off_grid_flag is true

Fix rate adjustments

Cambium Grid Climate Emissions and Updated AVERT

Bill-Becker · 2024-03-08T23:59:00Z

@adfarth have you run test_with_xpress.jl locally?

adfarth · 2024-03-11T04:01:54Z

@adfarth have you run test_with_xpress.jl locally?

Thank you for the reminder! I had not, but now I have and all tests have passed locally.

Bill-Becker

Is there breaking changes other than expected differences in emissions accounting and results when doing emissions reduction goals or CO2 cost in the optimization?

Otherwise, just a couple of questions about runtests.jl versus test_with_xpress.jl.

Bill-Becker · 2024-03-11T15:51:43Z

test/runtests.jl

@@ -1895,6 +1982,7 @@ else  # run HiGHS tests
                    end
                end 

+                # TODO: refresh tests and test values as needed after Cambium update; revised values are in test_with_xpress.jl


test_with_xpress.jl is using a different/updated Cambium version/data?

@Bill-Becker These are the emissions tests that Alex commented out a while back because they weren't compatible with the HiGHS solver. The test values are slightly updated because of the AVERT data update that we made in this PR. Alex added this note to indicate that once we are able to run these tests with a non-Xpress solver, we should update the values here. Does that all make sense?

Bill-Becker · 2024-03-11T15:53:44Z

test/test_with_xpress.jl

@@ -1377,6 +1377,82 @@ end
    @test calculated_ghp_capex ≈ reopt_ghp_capex atol=300
 end

+@testset "Cambium Emissions" begin


Is this the same test as in "runtests.jl" with the HiGHS solver? If so, we don't need to add it here. We should be prioritizing adding tests to runtests.jl with an open source solver whenever possible.

yes, this was exactly the same as the one in runtests. I deleted this testset in test_with_xpress in cb6d9d9

Bill-Becker · 2024-03-11T15:56:30Z

@adfarth also, just confirming again that you ran test_with_xpress.jl locally with this develop branch.

adfarth · 2024-03-11T17:38:01Z

@adfarth also, just confirming again that you ran test_with_xpress.jl locally with this develop branch.

Yes, confirmed that I ran this on the develop branch.

adfarth · 2024-03-11T17:58:26Z

Is there breaking changes other than expected differences in emissions accounting and results when doing emissions reduction goals or CO2 cost in the optimization?

Otherwise, just a couple of questions about runtests.jl versus test_with_xpress.jl.

Summary of changes at a high level:

Emissions results will change for all analyses (Cambium now used by default for climate emissions, health emissions from AVERT are updated to more recent version)
If an emissions reduction goal is added or CO2 cost considered in optimization, then optimal results will change
(Breaking based on change to inputs and outputs names) Updated electric_utility emissions_region to avert_emissions_region and distance_to_emissions_region_meters to distance_to_avert_emissions_region_meters in src/electric_utility.jl and results/electric_utility.jl
(Breaking for anyone using this export) Changed name of exported function emissions_profiles to avert_emissions_profiles
Changed calculation of all annual emissions results (e.g. Site.annual_emissions_tonnes_CO2) to simple annual averages (lifecycle emissions divided by analysis_years). This is because the default climate emissions from Cambium are already levelized over the analysis horizon and therefore "year_one" emissions cannot be easily obtained.

Bill-Becker

Thanks for the responses - they all look good. Related to the discussion of Xpress versus HiGHS tests - does anything you added with this PR require Xpress to work properly? We are about to take Xpress down from the publicly available API.

adfarth · 2024-03-12T04:16:22Z

Thanks for the responses - they all look good. Related to the discussion of Xpress versus HiGHS tests - does anything you added with this PR require Xpress to work properly? We are about to take Xpress down from the publicly available API.

Not that I can think of. I think there were some emissions modeling capabilities that were timing out or failing with HiGHS (hence the commented out tests in runtests), but those are not explicitly related to any change introduced by this PR (this is just changing the data sources, not any constraints)

adfarth added 30 commits June 23, 2023 14:46

start descriptions

5744ba1

some initial changes

b821ea9

initial commit for cambium integration

14cba62

using Cambium instead of AVERT for CO2 emissions by default

include off_grid_flag in ElectricUtility call when true

9388d7d

include other struct inputs to ElectricUtility when key not provided

7bef890

pass include_health_in_obj to Financial when key not provided

e3ac9ff

update default projected emissions decrease

40e58d0

Based on Cambium 2022 Mid-Case Scenario, LRMER CO2e (Combustion+Precombustion) 2024-2049 values

remove grid emissions from Site key for BAU runs

cb2470b

no longer an output under Site

combine AVERT functions, align emissions with load year

2b054fb

add cambium emissions region as output

8b69e81

under ElectricUtility

update help text

cd3a60e

make grid_level an input

08af697

end use or busbar

add auto adjust for emissions series if 8760 and ts > 1

d341165

Update electric_utility.jl

cd7a519

update tests with co2_from_avert = true

9e6f97b

This will prevent a Cambium API call with each unit test

add cambium_emissions_profile to REopt exports

1b9812f

Update runtests.jl

79cfc21

Merge branch 'develop' into cambium

cbad810

Merge branch 'develop' into cambium

81ed59a

Merge branch 'develop' into cambium

c584dfa

set emissions to zero for areas outside of AVERT

1bce45d

zero emissions for international

e9f20d6

temporary avoiding Cambium API call

4bd8190

temporary avoiding of Cambium call

2b58410

Update electric_utility.jl

49d577c

account for HI and AK

80090de

Merge branch 'develop' into cambium

7c105a8

add comma

a297a63

Update electric_utility.jl

c4314aa

zolanaj and others added 15 commits February 29, 2024 12:07

use emissions decrease defaults in electric utility and tests

77833eb

expand Cambium test suite

e74ed3e

Update CHANGELOG.md

919d859

Update CHANGELOG.md

556b37b

Merge remote-tracking branch 'origin/develop' into cambium

d7be87a

adding TODO for test values refresh for emissions and RE tests.

70cd420

Merge remote-tracking branch 'origin/develop' into cambium

f9399c8

Update CHANGELOG.md

ab3ae64

Merge branch 'develop' into rate-fix

ea87dbd

add a test

49b7538

fix test fn

565f5e2

Update runtests.jl

f2eb9ad

Merge pull request #352 from NREL/rate-fix

d6cb4cd

Fix rate adjustments

Merge branch 'develop' into cambium

5fa7896

Merge pull request #235 from NREL/cambium

f6155e7

Cambium Grid Climate Emissions and Updated AVERT

adfarth changed the title ~~v0.4.1~~ v0.41.0 master < develop Mar 8, 2024

adfarth marked this pull request as ready for review March 8, 2024 23:22

adfarth requested a review from Bill-Becker March 8, 2024 23:22

update changelog and version

9fa0b68

Bill-Becker reviewed Mar 11, 2024

View reviewed changes

update tests

cb6d9d9

Bill-Becker self-requested a review March 12, 2024 03:27

Bill-Becker approved these changes Mar 12, 2024

View reviewed changes

adfarth merged commit 677f3d9 into master Mar 12, 2024
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v0.41.0 master < develop #357

v0.41.0 master < develop #357

adfarth commented Mar 8, 2024 •

edited

Bill-Becker commented Mar 8, 2024

adfarth commented Mar 11, 2024 •

edited

Bill-Becker left a comment

Bill-Becker Mar 11, 2024

adfarth Mar 11, 2024

Bill-Becker Mar 11, 2024

adfarth Mar 11, 2024

Bill-Becker commented Mar 11, 2024

adfarth commented Mar 11, 2024

adfarth commented Mar 11, 2024 •

edited

Bill-Becker left a comment

adfarth commented Mar 12, 2024

v0.41.0 master < develop #357

v0.41.0 master < develop #357

Conversation

adfarth commented Mar 8, 2024 • edited

Bill-Becker commented Mar 8, 2024

adfarth commented Mar 11, 2024 • edited

Bill-Becker left a comment

Choose a reason for hiding this comment

Bill-Becker Mar 11, 2024

Choose a reason for hiding this comment

adfarth Mar 11, 2024

Choose a reason for hiding this comment

Bill-Becker Mar 11, 2024

Choose a reason for hiding this comment

adfarth Mar 11, 2024

Choose a reason for hiding this comment

Bill-Becker commented Mar 11, 2024

adfarth commented Mar 11, 2024

adfarth commented Mar 11, 2024 • edited

Bill-Becker left a comment

Choose a reason for hiding this comment

adfarth commented Mar 12, 2024

adfarth commented Mar 8, 2024 •

edited

adfarth commented Mar 11, 2024 •

edited

adfarth commented Mar 11, 2024 •

edited