-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cambium #475
Conversation
for potential future use in web tool
temporary
…youtputs_distance_to_avert_emissions_region.py
and make migrations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adfarth Thanks a bunch for this! My main comments are related to misplaced files or deleted files and there are a few minor other questions. Merge develop into cambium broke some things as well, and I'm still waiting to get Docker on my new laptop so I can test this thoroughly and maybe see if there's a fix, but my guess is merging migrations might fix the break. (Feel free to revert the merge as you see fit.)
reoptjl/migrations/0051_financialoutputs_lifecycle_mg_upgrade_and_fuel_cost_bau_and_more.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adfarth Looks great! Thanks for incorporating the changes. In addition to the added tests, I confirmed that you can get AVERT or Cambium results out of the job endpoint by altering the test post accordingly. I think this is good to merge.
@zolanaj Thank you for your review and for adding additional tests! |
Please check if the PR fulfills these requirements
Changed
Updated default fuel emissions factors from CO2 to CO2-equivalent (CO2e) values. In
reoptjl/models.py
, updated GeneratorInputs : emissions_factor_lb_CO2_per_gal from 22.51 to 22.58. And FUEL_DEFAULTS: emissions_factor_lb_CO2_per_mmbtu => Dict("natural_gas"=>116.9 to 117.03,
"landfill_bio_gas"=>114,8 to 115.38,
"propane"=>138.6 to 139.16,
"diesel_oil"=>163.1 to 163.61
)
Changed default source for CO2 grid emissions values to NREL's Cambium 2022 Database (by default: CO2e, long-run marginal emissions rates levelized (averaged) over the analysis period, assuming start year 2024). Added new emissions inputs in
ElectricUtilityInputs
. Include option for user to use AVERT data for CO2 using co2_from_avert boolian.Update
electric_utility
emissions_region to avert_emissions_region and distance_to_emissions_region_meters to distance_to_avert_emissions_region_meters.Added
v3/cambium_emissions_profile
tourls.py
,views.py
,http.jl
to obtain Cambium emissions profile. Mainly for use in web tool.ExistingBoilerInputs