Update CHP defaults from REopt.jl, Increase max size_class input to 7 #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reflects 2023 defaults changes
Bill-Becker
changed the title
Bill-Becker
approved these changes
Oct 11, 2023
…/REopt_API into update-max-chp-size-classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reflects 2023 CHP defaults changes
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
(Bug fix, feature, docs update, ...)
Bug Fix
What is the current behavior?
(You can also link to an open issue here)
Reciprocating engine, size class 7 return an error that CHPInputs.size_class must be <= 6
What is the new behavior (if this is a feature change)?
Reciprocating engine, size class 7 is accepted
Does this PR introduce a breaking change?
Yes for the results with different default inputs, but this was known because of expected defaults updates; we just didn't get the data in time to push with the other V3 updates.
none
Other information: