Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process is_electric_only in /chp_defaults endpoint #533

Merged
merged 5 commits into from
Oct 20, 2023

Conversation

zolanaj
Copy link
Collaborator

@zolanaj zolanaj commented Oct 20, 2023

Please check if the PR fulfills these requirements

  • CHANGELOG.md is updated
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

(Bug fix, feature, docs update, ...)
fix handling of is_electric_only in the /chp_defaults endpoint to allow for prime generator inputs to be retrieved

@zolanaj zolanaj changed the title process is_electric_only in /chp_defaults endpoint DNMY: process is_electric_only in /chp_defaults endpoint Oct 20, 2023
@zolanaj
Copy link
Collaborator Author

zolanaj commented Oct 20, 2023

@Bill-Becker I believe this, along with NREL/REopt.jl#301 should address the existing problems Erika encountered in the UI - her two posts are tests now. I added a "do not merge yet" tag on this PR as it currently points to the feature branch of REopt.jl related to the PR above; when the REopt.jl PR is merged with develop, then we can update the tag on this and merge + deploy for confirmation that things are working appropriately.

@zolanaj zolanaj changed the title DNMY: process is_electric_only in /chp_defaults endpoint process is_electric_only in /chp_defaults endpoint Oct 20, 2023
@zolanaj zolanaj merged commit aae4f6d into develop Oct 20, 2023
@zolanaj zolanaj deleted the setup-chp-defaults branch October 20, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants