Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chp defaults view #534

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Fix chp defaults view #534

merged 2 commits into from
Oct 24, 2023

Conversation

zolanaj
Copy link
Collaborator

@zolanaj zolanaj commented Oct 24, 2023

Please check if the PR fulfills these requirements

  • CHANGELOG.md is updated
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

(Bug fix, feature, docs update, ...)
Fixes bug in obtaining CHP defaults using django to call the endpoint instead of calling it directly.

What is the current behavior?

parameter is_electric_only is not added to inputs when calling http.jl from django, leading to a default value of "false"

What is the new behavior (if this is a feature change)?

is_electric_only = "true" is now appropriately received by the API, so Prime Generator technologies are created with appropriate adjustments to capital costs and tax incentives.

Does this PR introduce a breaking change?

(What changes might users need to make in their application due to this PR?)
No

Other information:

@zolanaj zolanaj merged commit d36b1e8 into develop Oct 24, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants