allow international wind #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adfarth
changed the title
adfarth
commented
Jan 31, 2024
| @@ -663,5 +663,5 @@ def lat_lon_in_windtoolkit(lat, lon): | |||
| y = int(round((point[1] - origin[1]) / 2000)) | |||
| y_max, x_max = (1602, 2976) | |||
| if (x < 0) or (y < 0) or (x >= x_max) or (y >= y_max): | |||
| raise ValueError("Latitude/Longitude is outside of wind resource dataset bounds.") | |||
| return None | |||
There was a problem hiding this comment.
By returning None the validation_error will be included in the output
There was a problem hiding this comment.
so the new behavior is to try and get wind resource data for any provided inputs. Sites which are truly beyond the international dataset will get a validation error from REopt?
There was a problem hiding this comment.
Sites beyond the international dataset that also do not provide production_factor_series will get an error (before all international sites did). See change to line 291
rathod-b
approved these changes
Feb 1, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
(Bug fix, feature, docs update, ...)
You previously could not run a Wind eval for a location outside of the WindToolkit bounds (e.g. international locations), due to the Wind validation code. This PR fixes this.
Other information: