Choose solver, add back V3 CI tests #565
Conversation
| @@ -117,7 +117,8 @@ docs/formulation/*log | |||
| /.werf_secret_key | |||
|
|
|||
| # Customized solver setup and docker files | |||
| julia_src/xpress/licenseserver | |||
| julia_src/xpress/ | |||
There was a problem hiding this comment.
this directory should no longer exist, correct? Is this a check just in case someone hasn't deleted it?
There was a problem hiding this comment.
Yes, it should no longer exist, but I'd rather keep this here as people transition over, just in case.
julia_src/http.jl
Outdated
| # Load Xpress only if it is installed, as indicated by ENV["XPRESS_INSTALLED"]="True" | ||
| xpress_installed = get(ENV, "XPRESS_INSTALLED", "False") | ||
| if xpress_installed == "True" | ||
| import Xpress # Why not "using Xpress"? |
There was a problem hiding this comment.
Updated to "using Xpress", and tested with V2 and V3
…hen not installed
| @@ -227,7 +227,7 @@ def test_superset_input_fields(self): | |||
| r = json.loads(resp.content) | |||
| results = r["outputs"] | |||
|
|
|||
| self.assertAlmostEqual(results["Financial"]["npv"], 11323.01, places=0) | |||
| self.assertAlmostEqual(results["Financial"]["npv"], -258533.19, places=-3) | |||
There was a problem hiding this comment.
Did just changing the solver change the result by this much?
There was a problem hiding this comment.
Ah, no, it's because I had to fix all of the technology sizes to avoid a timeout with the open source solver. Fixing the sizes still tests the capabilities here, which also implies the NPV test is not needed.
| @@ -27,14 +27,12 @@ jobs: | |||
| NREL_DEV_API_KEY: ${{ secrets.NREL_DEV_API_KEY }} | |||
There was a problem hiding this comment.
Should we consider renaming line 1 of this file and push_tests.yml?
|
Good catch and thanks for testing. I plan to go over this in the dev meeting tomorrow, and good to know we should just delete licenseserver and re-do those instructions. |
Settings.solver_name, and useful error messages if trying to use Xpress without installationtest_job_endpoint.pytests to use an open source solver so we can have full V3 CI testing again