Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wind outages outputs transpose fix #567

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Wind outages outputs transpose fix #567

merged 3 commits into from
Mar 12, 2024

Conversation

hdunham
Copy link
Collaborator

@hdunham hdunham commented Mar 7, 2024

Please check if the PR fulfills these requirements

  • CHANGELOG.md is updated
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

bug fix

What is the current behavior?

wind multi-dim outputs under Outages key were not structured the same as for other techs

What is the new behavior (if this is a feature change)?

multi-dim wind Outages outputs are now also transposed to account for Julia and python being column and row major

Does this PR introduce a breaking change?

(What changes might users need to make in their application due to this PR?)
no

Other information:

@hdunham hdunham requested a review from bpulluta March 7, 2024 17:28
Copy link
Collaborator

@bpulluta bpulluta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! That should fix the dictionary structure issue for Wind

@hdunham hdunham merged commit 8d85596 into develop Mar 12, 2024
1 check passed
@hdunham hdunham deleted the wind-outages-fix branch March 12, 2024 22:15
@adfarth adfarth restored the wind-outages-fix branch March 13, 2024 13:11
adfarth added a commit that referenced this pull request Mar 13, 2024
This reverts commit 8d85596, reversing
changes made to 7b0533c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants