-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use HiGHS solver by default and on production, include other OS solvers #574
Conversation
Bill-Becker
commented
Mar 29, 2024
•
edited
edited
- Change the default solver to HiGHS instead of Xpress
- Remove Xpress for production API on NREL servers
- End-of-Life for v1 and v2 of the API which relied on Xpress on NREL servers
- Increase default timeout limit to 600 seconds (10 mins), and increase the max to 1200 seconds (20 mins) to allow slower solvers enough time to solve certain scenarios
- Increased the max optimality tolerance to 0.2 (20%) as a tool to debug long solve times and narrow in on a solution with decreased tolerance (keep default at 0.001 (0.1%)
mining operations may use > 1,000 GWh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Bill-Becker! One non-critical comment with the approval.
validators=[ | ||
MinValueValidator(1), | ||
MaxValueValidator(420) | ||
MaxValueValidator(1200) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no harm in going higher for API users, like 3600 as the max - since harder problems might need more time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be fine with a larger timeout for local/other-server running the API, but I don't want to clog up the NREL servers with super-long running runs. That's actually the main motivation for keeping this reasonably low.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me! Thanks for clarifying.