Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HiGHS solver by default and on production, include other OS solvers #574

Merged
merged 13 commits into from
Mar 30, 2024

Conversation

Bill-Becker
Copy link
Collaborator

@Bill-Becker Bill-Becker commented Mar 29, 2024

  • Change the default solver to HiGHS instead of Xpress
  • Remove Xpress for production API on NREL servers
  • End-of-Life for v1 and v2 of the API which relied on Xpress on NREL servers
  • Increase default timeout limit to 600 seconds (10 mins), and increase the max to 1200 seconds (20 mins) to allow slower solvers enough time to solve certain scenarios
  • Increased the max optimality tolerance to 0.2 (20%) as a tool to debug long solve times and narrow in on a solution with decreased tolerance (keep default at 0.001 (0.1%)

@Bill-Becker Bill-Becker changed the base branch from master to develop March 29, 2024 21:38
Copy link
Collaborator

@zolanaj zolanaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Bill-Becker! One non-critical comment with the approval.

validators=[
MinValueValidator(1),
MaxValueValidator(420)
MaxValueValidator(1200)
Copy link
Collaborator

@zolanaj zolanaj Mar 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no harm in going higher for API users, like 3600 as the max - since harder problems might need more time.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be fine with a larger timeout for local/other-server running the API, but I don't want to clog up the NREL servers with super-long running runs. That's actually the main motivation for keeping this reasonably low.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! Thanks for clarifying.

@Bill-Becker Bill-Becker merged commit dcb896c into develop Mar 30, 2024
2 checks passed
@Bill-Becker Bill-Becker deleted the os-solver branch March 30, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants