Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v 3.8.0 master < develop PV tilt angle default update and option whether to apply batt mis SOC during outages #579

Merged
merged 58 commits into from
Apr 29, 2024

Conversation

bpulluta
Copy link
Collaborator

@bpulluta bpulluta commented Apr 24, 2024

Please check if the PR fulfills these requirements

  • CHANGELOG.md is updated
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

(Bug fix, feature, docs update, ...)

default update for 'PV tilt'.

  • In core/pv.jl a change was made to make sure we are using the same assumptions as PVWatts guidelines, the default tilt angle for a fixed array should be 20 degrees, irrespective of it being a rooftop (0) or ground-mounted (open-rack)(1) system. By default the tilt will be set to 20 degrees for fixed ground-mount and rooftop, and 0 degrees for axis-tracking (array_type = (2), (3), or (4))

What is the current behavior?

(You can also link to an open issue here)

  • The current default PV tilt angle for a rooftop is set to 10 degrees and for fixed ground-mount to 20 degrees.

  • ElectricStorageInputs input soc_min_fraction always applies during outages

What is the new behavior (if this is a feature change)?

  • The new behavior sets the tilt angle for fixed PV rooftop and ground-mount to 20 degrees and for axis-tracking to 0 degrees. This aligns it with the pvwatts defaults.

  • Added soc_min_applies_during_outages boolean field to ElectricStorageInputs (defaults to false)

Does this PR introduce a breaking change?

(What changes might users need to make in their application due to this PR?)

  • Specify a PV tilt angle if they may need to use a lower tilt angle for their fixed arrays than the new default of 20 due to hardware cost, wind, or other consideration consideration

  • Specify soc_min_applies_during_outages in inputs if you would like it to be true

Other information:

@bpulluta bpulluta requested a review from adfarth April 24, 2024 20:02
@bpulluta bpulluta requested a review from hdunham April 25, 2024 18:39
CHANGELOG.md Outdated Show resolved Hide resolved
@bpulluta bpulluta removed the request for review from adfarth April 29, 2024 15:53
@bpulluta bpulluta merged commit 3ba6a3e into master Apr 29, 2024
1 check passed
@hdunham hdunham changed the title v 3.7.1 master < develop PV tilt angle default update v 3.8.0 master < develop PV tilt angle default update and option whether to apply batt mis SOC during outages May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants