-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v 3.8.0 master < develop PV tilt angle default update and option whether to apply batt mis SOC during outages #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdunham
reviewed
Apr 26, 2024
hdunham
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
(Bug fix, feature, docs update, ...)
default update for 'PV tilt'.
core/pv.jl
a change was made to make sure we are using the same assumptions as PVWatts guidelines, the defaulttilt
angle for a fixed array should be 20 degrees, irrespective of it being a rooftop(0)
or ground-mounted (open-rack)(1)
system. By default thetilt
will be set to 20 degrees for fixed ground-mount and rooftop, and 0 degrees for axis-tracking (array_type = (2), (3), or (4)
)What is the current behavior?
(You can also link to an open issue here)
The current default
PV tilt angle
for a rooftop is set to 10 degrees and for fixed ground-mount to 20 degrees.ElectricStorageInputs input soc_min_fraction always applies during outages
What is the new behavior (if this is a feature change)?
The new behavior sets the tilt angle for fixed PV rooftop and ground-mount to 20 degrees and for axis-tracking to 0 degrees. This aligns it with the pvwatts defaults.
Added soc_min_applies_during_outages boolean field to ElectricStorageInputs (defaults to false)
Does this PR introduce a breaking change?
(What changes might users need to make in their application due to this PR?)
Specify a
PV tilt angle
if they may need to use a lower tilt angle for their fixed arrays than the new default of 20 due to hardware cost, wind, or other consideration considerationSpecify soc_min_applies_during_outages in inputs if you would like it to be true
Other information: