Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Erroneous PPA model warning message with battery replacements #516

Closed
sjanzou opened this issue Jan 29, 2021 · 2 comments
Closed

Erroneous PPA model warning message with battery replacements #516

sjanzou opened this issue Jan 29, 2021 · 2 comments
Assignees
@sjanzou
Labels
bug
Milestone
2020.11.29 Patch 1

Comments

@sjanzou
Copy link
Collaborator

sjanzou commented Jan 29, 2021

Forum post:

https://sam.nrel.gov/forum/forum-general/3315

image
image
@sjanzou sjanzou added the bug label Jan 29, 2021
@sjanzou sjanzou self-assigned this Jan 29, 2021
@sjanzou sjanzou added this to the 2020.11.29 Patch 1 milestone Jan 29, 2021
@sjanzou
Copy link
Collaborator Author

sjanzou commented Jan 29, 2021

Remove dialog and warning text in PPA soln mode and Batt Replacement callbacks after testing with attached project file per document.
Forum2021.1.28_issue_3315.docx

Test project file with PV-Batt fixed PPA and target IRR and Fuel Cell and generic battery referenced in above docuemnt
default-fom-batt-specify-irr-mode-sam-2020-11-29_sj.zip

sjanzou added a commit that referenced this issue Jan 29, 2021
@sjanzou
Remove erroneous warning message about target IRR mode with battery r…
a6efbec 
…eplacements - address #516
sjanzou added a commit that referenced this issue Jan 30, 2021
@sjanzou
Merge pull request #517 from NREL/SAM_516
ee121f8 
Address issue #516 into patch
sjanzou added a commit that referenced this issue Jan 30, 2021
@sjanzou
Merge pull request #519 from NREL/SAM_516
4390929 
Fix issue #516 on develop - same as approved pull request #517 merging SAM_516 into patch
@sjanzou
Copy link
Collaborator Author

sjanzou commented Jan 30, 2021

Fixed with PR#517 into patch and #519 into develop

@sjanzou sjanzou closed this as completed Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjanzou sjanzou

Labels
bug
Projects
None yet
Milestone
2020.11.29 Patch 1
Development

No branches or pull requests
1 participant
@sjanzou