Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix input grid power target UI issues #988

Merged
merged 1 commit into from
Mar 19, 2022
Merged

Fix input grid power target UI issues #988

merged 1 commit into from
Mar 19, 2022

Conversation

cpaulgilman
Copy link
Collaborator

Description

  • Fix default value of batt_target_power very small number instead of zero.

  • Improve text description of grid power target and battery power target options.

  • Improve labels in monthly and time series data input windows.

  • Remove leading space from standalone battery input variable label

Fixes #971

Type of change

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • [ x] My code follows the style guidelines of this project
  • [ x] I have performed a self-review of my own code
  • [ x] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [x ] My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • [ x] New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@cpaulgilman
Fix input grid power target UI issues
2df3860 
* Fix default value of `batt_target_power` very small number instead of zero.

* Improve text description of grid power target and battery power target options.

* Improve labels in monthly and time series data input windows.

* Remove leading space from standalone battery input variable label
@cpaulgilman cpaulgilman added this to the 2021.12.02 Patch 2 milestone Mar 18, 2022
@cpaulgilman cpaulgilman self-assigned this Mar 18, 2022
brtietz
brtietz approved these changes Mar 18, 2022
View reviewed changes
Copy link
Collaborator

@brtietz brtietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@cpaulgilman cpaulgilman merged commit e9ed058 into patch Mar 19, 2022
@cpaulgilman cpaulgilman deleted the batt_dispatch_ui_fixes branch March 19, 2022 00:36
brtietz added a commit that referenced this pull request Mar 31, 2022
@brtietz @sjanzou @cpaulgilman
Patch into develop 3/31/2022 (#997)
a8f10e5 
* Testing Puerto Rico Wizard setup

* First iteration of Puerto Rico mini grid wizard

* Update project file and script

* Updates  based on meeting

* LCOE versus unmet load percentage added to wizard

* Add total cost per participant output plots to wizard and parametrics table

* Update Puerto Rico Mini Grid wizard output plots per email from Nate

* parametricviewer import function still failing.

* Update Puerto Rico Mini Grid wizard per 3/8/2022 meeting

* Fix PuertoRicoWeatherDir to remove extra forward slash

* Updates so that parametricviewer export and import work consistently

* Fix windows build issue using Item(ndx) rather than At(ndx) in Simulation::ListAllOutputs

* Fix run time issue with fcall_parametric_import and update wizard and template file

* Update wizard and template file for latest sizing algorithm

* Puerto Rico Mini Grid wizard now working and ready for review

* Code cleanup

* Clean up mini-grid wizard

Remove "Puerto Rico" from file names and descriptive text.

Edit wizard text for clarity and remove milisleep() pauses after msgbox().

Use consistent case for wizard LK script file names to clean up wizard list on Welcome page.

* Fix input grid power target UI issues (#988)

* Fix default value of `batt_target_power` very small number instead of zero.

* Improve text description of grid power target and battery power target options.

* Improve labels in monthly and time series data input windows.

* Remove leading space from standalone battery input variable label

* Fix RE-only scenario (#982)

* Set battery capacity to zero instead of using en_batt to disable battery.

* Add user feedback about disabling battery.

* Get forecasts working for generic battery by running generic system with an 8760 production profile

* clean up scripts for stand alone battery and defaults based on test results

* update required defaults for fuel cell

* Help revisions for "generation" vs "production"

* Swap labels from production to generation as appropriate

* Align widget with ones below to avoid overlap issues in Linux/Mac

Co-authored-by: Steven Janzou <sjanzou@gmail.com>
Co-authored-by: Steven Janzou <steve@janzouconsulting.com>
Co-authored-by: Paul Gilman <cpaulgilman@gmail.com>
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brtietz brtietz brtietz approved these changes

Assignees

@cpaulgilman cpaulgilman

Labels
added to release notes PR and/or issue has been added to release notes for a public release
Projects
None yet
Milestone
2021.12.02 Patch 2
Development

Successfully merging this pull request may close these issues.

Battery Dispatch Input Grid Power Targets UI issues
2 participants
@cpaulgilman @brtietz