Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GUI GCR and Pitch #143

Closed
shirubana opened this issue Aug 29, 2019 · 2 comments
Closed

GUI GCR and Pitch #143

shirubana opened this issue Aug 29, 2019 · 2 comments
Labels
v0_3_3 Include for 0.3.3 release

Comments

@shirubana
Copy link
Member

Even if GCR is selected, if Pitch value (greyed out) has a value, then it sets the scene to PITCH value at least on Scene View
@cdeline
Copy link
Contributor

cdeline commented Oct 10, 2019

We should make the GUI calculate GCR or Pitch when one or the other is entered. That way, either GCR or pitch would give the same answer in modelchain. This could still be an issue if people set up a .ini file with inconsistent pitch and GCR, in which case Pitch is read in first.

@cdeline cdeline added the v0_3_3 Include for 0.3.3 release label Oct 10, 2019
@cdeline cdeline mentioned this issue Oct 11, 2019
Merged
cdeline added a commit that referenced this issue Oct 13, 2019
@cdeline
Merge branch '0_3_2_bugfixes' of https://github.com/NREL/bifacial_rad…
6193332 
…iance into 0_3_2_bugfixes.  Fixes #143
@cdeline
Copy link
Contributor

cdeline commented Oct 13, 2019

Rather than calculating GCR from Pitch in the GUI, we instead just pass one or the other, depending on which is selected from GCRorPitch. Fixed in 0.3.2bugfixes branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v0_3_3 Include for 0.3.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shirubana @cdeline