More refactoring make module #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decided not to do readTrackerAngles because metObj saves a reduced metdata without the night hours and it's going to be hard to align the data or would have to rerun metdata file, so let's just make users add their trackerdata to the weatherfile. If this function ends up being needed it can be added once we have a real use example/need. also added pytest
This example kinda shows how to solve #344
fix for missingKeyWarning units #351
We keep calling this in journals and I think they need to be on our performance (or analysis) module
…clarity and to avoid double negative.
This helps streamline the documentation and usage of the refactored ModuleObj.
…luding backward compatibility.
|
@shirubana - I think this one is ready to get merged. I've double checked all notebooks, pytests and checked for backward compatiblity from previous scripts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues refactoring the ModuleObj by allowing true OOP by doing module.addTorquetube() and module.addCellModule().
TODO: