change DataError from core.base to pandas.errors

[paulf81]

I believe ready to be merged

Feature or improvement description
I recently had an error that the DataError class was not a member of core.base and found it instead in pandas.errors, maybe this is just something that changed in pandas versions? I'm running 1.4.4

@Bartdoekemeijer does this change make any trouble for you?

[Bartdoekemeijer]

Are you sure you are running Pandas 1.4.4 and not 1.5? Checking out the Pandas changelog of 1.5, I find:
https://pandas.pydata.org/pandas-docs/stable/whatsnew/v1.5.0.html#backwards-incompatible-api-changes

and specifically, DataError was moved to the errors submodule in this PR: pandas-dev/pandas#47047.

I'm okay with the changes you suggest @paulf81 -- generally it's great to track the latest pandas version. Could you update requirements.txt and setup.py to enforce pandas>=1.5.0?

[misi9170]

Confirming @Bartdoekemeijer 's comment---the suggested changes work for me with pandas==1.5, but not with pandas==1.4.4. I agree that the requirements should be updated to pandas>=1.5 prior to merging.

[paulf81]

Nice catch guys! Thank you! I added the updated requirements, good to pull?

[misi9170]

Looks good to me, feel free to merge

[paulf81]

@misi9170 cool if I first merge the isocalendar pull into this one? I think will go easier as a cascade

[codecov-commenter]

Codecov Report

❗ No coverage uploaded for pull request base (develop@515752c). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff             @@
##             develop      #24   +/-   ##
==========================================
  Coverage           ?   34.60%           
==========================================
  Files              ?       38           
  Lines              ?     3627           
  Branches           ?        0           
==========================================
  Hits               ?     1255           
  Misses             ?     2372           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[paulf81]

Tests all pass merging!