-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: revamp of wind speed-power curve filtering class #78
Feature: revamp of wind speed-power curve filtering class #78
Conversation
…ollapse previous raw data processing steps in ws_pow_filtering. Also, generalize plots. Remove dependency on OpenOA for time being to resolve dependency issue.
See the pull request on flasc_cookiecutter_template for an example of the new functionalities. |
I like it Bart, agree it's neat and readable! OK to merge from my end, thank you! |
@Bartdoekemeijer I agree, this looks really nice, sorry that I haven't put a comment in before now. I was hoping to get it tested using the flasc_cookiecutter_template, but still haven't quite figured out how to run things there based on your fork. If you'd like to get this in ASAP, I think you can go ahead and merge; otherwise, I'll hopefully be able to add a proper review once we've met next week! |
@misi9170 no worries, this can wait until next week! Happy to have your comments! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Bartdoekemeijer; all looks good to me, both here and in flasc_cookiecutter_template. I'm going to go ahead and approve and then merge both.
This PR is not yet ready to be merged.
Feature or improvement description
This is a revamp of the windspeed-power curve filtering class. Specifically, it collapses steps 2-4 from the raw data processing workflow into a single processing step. It also provides a much more generic interface for filters and related insightful plots.
Related issue, if one exists
This resolves #67 but that's not the focus of this contribution.
Impacted areas of the software
The
turbine_analysis
subfolder.Additional supporting information
The interface has a number of major changes:
This does increase the length of a user's code, but I think it's particularly helpful and insightful. Users can be very particular in their queries, and as complex as they like. Each query is saved and linked to particular data indices in the dataset, which can then be plotted. See the test results below.
Test results, if applicable
Will open a pull request in the
flasc_cookiecutter_template
, but here's the relevant code snippet:And yields
and
![image](https://user-images.githubusercontent.com/22119448/228301881-539019c0-962f-404f-9d90-fc7a058a2f06.png)
![image](https://user-images.githubusercontent.com/22119448/228301860-77d89886-b5bc-4391-84fd-0d2304c1f074.png)
![image](https://user-images.githubusercontent.com/22119448/228301900-9897699f-6efd-49f7-a2b0-be0f23423104.png)
To do before merging, in no particular order:
ws_pow_filtering
toturbine_filtering
flasc_cookiecutter_template