Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: properly assign reference turbine location in calculating closest subset of turbines #99

Merged

Conversation

Bartdoekemeijer
Copy link
Collaborator

This PR is ready to be merged.

Feature or improvement description
This fixes a bug in which the relative distance between turbines is not properly calculated when assigning reference values by the closest N number of turbines.

Related issue, if one exists
N/A

Impacted areas of the software
Dataframe manipulations.

Additional supporting information
N/A

Test results, if applicable
N/A

Copy link
Collaborator

@paulf81 paulf81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching @Bartdoekemeijer !

@Bartdoekemeijer Bartdoekemeijer merged commit 8f20ac9 into NREL:main Jul 7, 2023
2 checks passed
@Bartdoekemeijer Bartdoekemeijer deleted the bug_fix/set_by_n_closest_turbines branch July 7, 2023 05:23
@misi9170 misi9170 mentioned this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants