renaming: power_opt to power_init in _get_initial_farm_power() #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bayc
approved these changes
Feb 3, 2021
|
@gogannes Thanks for this change! I agree it helps make the code more clear. I will merge this shortly with a handful of other pull requests. |
|
Cool thanks! =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete this sentence
THIS PULL REQUEST IS READY TO MERGE
Feature or improvement description
I guess someone forgot to rename variables during a copy/paste when introducing the function _get_initial_farm_power()
It doesn't make sense to call the variables here "_opt", therefore some renaming to avoid confusion.
Related issue, if one exists
Impacted areas of the software
none
Additional supporting information
It's my first pull request, so please let me know if something is not right :)
Test results, if applicable
I run examples/optimization/scipy/controls_optimization/optimize_yaw_wind_rose.py