Issue alert if calc wake needs to be run #432
Conversation
examples/make_error.py
Outdated
| @@ -0,0 +1,15 @@ | |||
|
|
|||
There was a problem hiding this comment.
This is nice to demonstrate, but we should remember to remove this example file before merging
floris/tools/floris_interface.py
Outdated
| @@ -558,12 +558,20 @@ def check_wind_condition_for_viz(self, wd=None, ws=None): | |||
| if len(ws) > 1 or len(ws) < 1: | |||
| raise ValueError("Wind speed input must be of length 1 for visualization. Current length is {}.".format(len(ws))) | |||
|
|
|||
| def check_calc_wake_run(self, func_name): | |||
There was a problem hiding this comment.
Maybe make this private, _check_calc_wake_run?
There was a problem hiding this comment.
Good suggestion, changed it
floris/tools/floris_interface.py
Outdated
| @@ -558,12 +558,20 @@ def check_wind_condition_for_viz(self, wd=None, ws=None): | |||
| if len(ws) > 1 or len(ws) < 1: | |||
| raise ValueError("Wind speed input must be of length 1 for visualization. Current length is {}.".format(len(ws))) | |||
|
|
|||
| def check_calc_wake_run(self, func_name): | |||
There was a problem hiding this comment.
Maybe make this private, _check_calc_wake_run?
floris/tools/floris_interface.py
Outdated
| def get_turbine_powers(self) -> NDArrayFloat: | ||
| """Calculates the power at each turbine in the windfarm. | ||
|
|
||
| Returns: | ||
| NDArrayFloat: [description] | ||
| """ | ||
|
|
||
| self.check_calc_wake_run('get_turbine_powers') |
There was a problem hiding this comment.
Nice! We also need to add it to get_farm_power, and maybe some of the visualization functions?
floris/tools/floris_interface.py
Outdated
| def get_turbine_powers(self) -> NDArrayFloat: | ||
| """Calculates the power at each turbine in the windfarm. | ||
|
|
||
| Returns: | ||
| NDArrayFloat: [description] | ||
| """ | ||
|
|
||
| self.check_calc_wake_run('get_turbine_powers') |
There was a problem hiding this comment.
Nice! We also need to add it to get_farm_power, and maybe some of the visualization functions?
# Conflicts: # floris/tools/floris_interface.py
|
I'm not totally convinced about this |
|
@rafmudaf, I'm not totally convinced on it, though not opposed either, but I've also never quite found |
I'm not tied to the |
| @@ -631,6 +639,10 @@ def get_farm_power( | |||
| # for turbine in self.floris.farm.turbines: | |||
| # turbine.use_turbulence_correction = use_turbulence_correction | |||
|
|
|||
| # Confirm calculate wake has been run | |||
| if self.floris.state is not State.USED: | |||
There was a problem hiding this comment.
@paulf81 I think we do not need this here since it would be caught by self.get_turbine_powers(). Do you agree?
There was a problem hiding this comment.
that makes sense to me, maybe this could be deleted and then we can make a test we get an error if calc wake not run before get_turbine_powers?
Just a first pass at an idea to address Issue #431
@Bartdoekemeijer what do you think?
Feature or improvement description
Check a certain attribute exists to determine if calc wake needs to be run
Related issue, if one exists
Issue #431