-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3.2 #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove remnants of uncertainty modeling in floris_interface * Remove get_turbine_power and farm power legacy functions that are already commented out * Remove additional commented code Co-authored-by: Rafael M Mudafort <rafael.mudafort@nrel.gov> Co-authored-by: Rafael M Mudafort <rafmudaf@gmail.com>
This is left over from v2 and not used in v3. Currently, we map model strings to model definitions directly in the Wake class.
Clean up and simplify some things
* enabling time series calculation of wind conditions * Add an example using time series Co-authored-by: Rafael M Mudafort <rafmudaf@gmail.com> Co-authored-by: Paul <paul.fleming@nrel.gov>
…face.reinitalize` (#470) * split layout into x and y components * update the uncertainty inferace to match the new layout input * update examples to use layout_x and layout_y * update notebook example to get QA checks passing * bring pre-commit settings up to date * add layout back but map to x,y inputs with deprecation warning * swtich to logger warning
* first pass * switch to private and check on get_farm_power * bugfix * Check BaseClass state for flow control in FI * Remove failing example * FIx missing import * Reduce state-enum to three states Co-authored-by: Rafael M Mudafort <rafmudaf@gmail.com>
Co-authored-by: Rafael M Mudafort <rafmudaf@gmail.com>
* add deflection to the turbopark model * Add yawed reg test * Add warning when using wake deflection with the TurbOPark model * simplifying check for yaw angles in turbopark deflection Co-authored-by: Rafael M Mudafort <rafmudaf@gmail.com>
* Add a forced max of 3 to turbine grid points * Error when using more than 3 turbine grid points * Reduce turbine grid points in example input * Error bug fix Co-authored-by: Rafael M Mudafort <rafael.mudafort@nrel.gov> Co-authored-by: Rafael M Mudafort <rafmudaf@gmail.com>
…d point (#476) * calculate dudz_initial analytically to support using only 1 rotor grid point * Updating regression tests
* Add turbine_weights option in get_farm_power and get_farm_aep * Reflect turbine_weights functionality in uncertainty_interface * Bug fix: add turbine_weights option in uncertainty_interface.get_farm_power * Preliminary example of yaw optimization with a neighboring farm * Add a smaller example to show syntax for t_weights * updating example numbering * update examples to be excluded from testing due to renumbering of examples Co-authored-by: Paul <paul.fleming@nrel.gov> Co-authored-by: bayc <christopher.j.bay@gmail.com>
* add the base layout optimization class * add the scipy layout optimzation class * add the pyoptsparse layout optimization class * add boundary grid functions for layout optimization * removing print statements * adding check for second turbine * add the base layout optimization class * add the scipy layout optimzation class * add the pyoptsparse layout optimization class * add boundary grid functions for layout optimization * adding check for second turbine * making variables private; using fi.get_farm_AEP in obj functions; removing hard-coding of rho for space constraint * updating scipy layout optimization class * updating pyoptsparse layout optimization class * updating layout optimizaiton base class * updating layout optimization example * moving old optimization code into legacy folder * removing _reinitialize method from pyoptsparse layout optimization * add extra output to example Co-authored-by: Paul <paul.fleming@nrel.gov>
* add ref density term to yaml inputs * route ref_density_cp_ct through init codes * add ref_density to code * Add a clear error about reference air density * add ref density to unit test * Add ref density to regression tests * Issue a warn, apply the default 1.225 if not def Co-authored-by: bayc <christopher.j.bay@gmail.com>
* Add function to read in wind rose as csv * add aep function which accepts wind rose object * add an example using wind rose object aep * update how no_wake is passed * Add label option * add x_20 turbine option * adding check for second turbine * add time limit and storeHistory options * add hotStart option * call get_farm_aep from within the wind rose ver * add deflection to the turbopark model * Add a simplified spreading optimization * changing 'layout' to 'layout_x/layout_y' * renumbering examples Co-authored-by: bayc <christopher.j.bay@gmail.com>
paulf81
approved these changes
Sep 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks for putting together @rafmudaf !
* adding missing time_series flag to cc flow field solver call * adding documentation for the time_series flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
Merge
develop
intomain
for v3.2 release.Additional supporting information
Proposed release notes are below.
Release Checklist
Change Log
#424 Bugfix: using the wrong rotor diameters when plotting with the CC model
#428 Feature: Expand capabilities of UncertaintyInterface
#397 Remove commented and legacy code in floris_interface.py
#437 Clean up and simplify some things
#438 BugFix: Avoid negative square root in Cumulative Curl model
#400 Enabling vectorized time series calculation of wind conditions
#440 Update 07_calc_aep_from_rose.py
#452 Add method to return turbine TIs
#423 Add example of getting wind speeds at turbines
#456 pass in het map when copying fi
#470 Bug fix: Convert
layout
tolayout_x
andlayout_y
inFlorisInterface.reinitalize
#432 Issue alert if calc wake needs to be run
#445 Fix bug in
plot_turbines_with_fi
#439 Add wake deflection to the TurbOPark wake deficit model
#472 Add a forced max of 3 to turbine grid points
#476 calculate dudz_initial analytically to support using only 1 rotor grid point
#435 Feature: Add turbine_weights option in get_farm_power and get_farm_aep
#429 Layout optimization refactoring
#398 Feature/add ref density
#392 Update wind rose and power rose
#497 add ref density to legacy reader
#493 adding missing time_series flag to cc flow field solver call