Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix: initialize TI array with correct dimensions #584

Merged
merged 11 commits into from Mar 6, 2023
Merged

Bug fix: initialize TI array with correct dimensions #584

merged 11 commits into from Mar 6, 2023

Conversation

bayc
Copy link
Collaborator

@bayc bayc commented Feb 16, 2023

Feature or improvement description
This bug fix corrects the shape of the turbulence_intensity_field for use with the calculate_no_wake function.

Related issue, if one exists
#572

Impacted areas of the software
flow_field.py

Additional supporting information
This PR also adds a unit test for calculate_no_wake.

Test results, if applicable
The following code runs without error.

from floris.tools import FlorisInterface

fi = FlorisInterface("inputs/gch.yaml")

fi.calculate_no_wake()
TIs = fi.get_turbine_TIs()

@bayc bayc requested a review from rafmudaf February 16, 2023 17:27
@bayc bayc self-assigned this Feb 16, 2023
@bayc bayc added the bug Something isn't working label Feb 16, 2023
@bayc bayc requested a review from rafmudaf March 2, 2023 18:30
@rafmudaf
Set array shape with n_turbine over array size
cb14201 
This allows for flexibility with other grid types and it’s more explicit
@rafmudaf rafmudaf mentioned this pull request Mar 3, 2023
Merged
@rafmudaf rafmudaf changed the title Bugfix: sorting TIs with calculate no wake Bug fix: initialize TI array with correct dimensions Mar 6, 2023
@rafmudaf rafmudaf merged commit b796bd0 into NREL:main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafmudaf rafmudaf Awaiting requested review from rafmudaf

Assignees

@bayc bayc

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bayc @rafmudaf