Update multidim turbine files to use absolute turbine power #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bayc
added
enhancement
bayc
force-pushed
the
update_multi_dim_to_abs_power
branch
from
b9dc273
to
9402f3d
Compare
misi9170
approved these changes
Feb 22, 2024
rafmudaf
reviewed
Feb 22, 2024
rafmudaf
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the multi-dimensional Cp/Ct capability to use absolute turbine power
This PR updates the multi-dimensional Cp/Ct functionality to use the absolute turbine power convention that has been adopted throughout the other turbine code/models. The changes themselves are pretty targeted, focusing on the input file for the multidim IEA 15MW turbine definition.
Related issue
None.
Impacted areas of the software
turbine.py,turbine_library, andtests.Additional supporting information
Note that a full multidim turbine definition has been added to the test setup to make the multidim tests based on the IEA 15MW accurate. Previously, it was using a hybrid of the NREL 5MW and the IEA 15MW unintentionally.
Test results, if applicable
Tests are passing.