Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update multidim turbine files to use absolute turbine power #818

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

bayc
Copy link
Collaborator

@bayc bayc commented Feb 22, 2024

Update the multi-dimensional Cp/Ct capability to use absolute turbine power

This PR updates the multi-dimensional Cp/Ct functionality to use the absolute turbine power convention that has been adopted throughout the other turbine code/models. The changes themselves are pretty targeted, focusing on the input file for the multidim IEA 15MW turbine definition.

Related issue

None.

Impacted areas of the software

turbine.py, turbine_library, and tests.

Additional supporting information

Note that a full multidim turbine definition has been added to the test setup to make the multidim tests based on the IEA 15MW accurate. Previously, it was using a hybrid of the NREL 5MW and the IEA 15MW unintentionally.

Test results, if applicable

Tests are passing.

@bayc bayc self-assigned this Feb 22, 2024
@bayc bayc added enhancement An improvement of an existing feature v4 Focus of FLORIS v4 labels Feb 22, 2024
@bayc bayc added this to the v4.0 milestone Feb 22, 2024
@bayc bayc force-pushed the update_multi_dim_to_abs_power branch from b9dc273 to 9402f3d Compare February 22, 2024 17:21
@rafmudaf rafmudaf self-requested a review February 22, 2024 22:15
@rafmudaf rafmudaf merged commit 308f176 into NREL:v4 Feb 22, 2024
8 checks passed
@misi9170 misi9170 mentioned this pull request Apr 8, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature v4 Focus of FLORIS v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants