Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicit chemisty implementation #3

Merged
merged 5 commits into from
Jul 20, 2023
Merged

Implicit chemisty implementation #3

merged 5 commits into from
Jul 20, 2023

Conversation

moprak-nrel
Copy link
Collaborator

Add a routine that can handle implicit chemistry time advancement, along with a "Strang" splitting time stepping between the flow and chemistry solves.

Copy link
Collaborator

@hsitaram hsitaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an example inputs file for blockCatalyst1d with the implicit integrator?
Also, anything like SUNDIALS_LIB_DIR that I need to set in the GNUMakefile, can you add that in the blockCatalyst1d as a commented line

@moprak-nrel
Copy link
Collaborator Author

Added the implicit options in the blockCatalyst1d directory.

The implicit integration was verified for this case with k=5*1e5 instead of k=5, at this rate the explicit chemistry does not work, but the implicit version works as expected.

@moprak-nrel
Copy link
Collaborator Author

moprak-nrel commented Jul 20, 2023

Verification of the implicit solve: x direction was run with new implicit solve, y direction used new explicit RK3, z direction is the current explicit implementation. This is for the k=5 case.

verification.pdf

@hsitaram hsitaram merged commit 4bffb63 into main Jul 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants