Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/ext door prm #1294

Merged
merged 2 commits into from
Mar 29, 2022
Merged

Fix/ext door prm #1294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5adbf2c
Fix prm standards construction type for Rollup doors
mdahlhausen Mar 29, 2022
2eaa3f7
add name case coverage for prm ext doors
mdahlhausen Mar 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 15 additions & 0 deletions lib/openstudio-standards/standards/Standards.PlanarSurface.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,21 @@ def planar_surface_apply_standard_construction(planar_surface, climate_zone, pre
OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.PlanarSurface', "Could not determine the standards fenestration type for #{planar_surface.name} from #{construction.name}. This surface will not have the standard applied.")
return previous_construction_map
end
# Exterior Doors
elsif surf_type == 'ExteriorDoor'
stds_type = standards_info.standardsConstructionType
if stds_type.is_initialized
stds_type = stds_type.get
case stds_type
when 'RollUp', 'Rollup', 'NonSwinging', 'Nonswinging'
stds_type = 'NonSwinging'
else
stds_type = 'Swinging'
end
else
OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.PlanarSurface', "Could not determine the standards construction type for exterior door #{planar_surface.name}. This door will not have the standard applied.")
return previous_construction_map
end
# All other surface types
else
stds_type = standards_info.standardsConstructionType
Expand Down
15 changes: 15 additions & 0 deletions lib/openstudio-standards/standards/deer/deer.PlanarSurface.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,21 @@ def planar_surface_apply_standard_construction(planar_surface, climate_zone, pre
OpenStudio.logFree(OpenStudio::Warn, 'openstudio.model.PlanarSurface', "Could not determine the standards fenestration type for #{planar_surface.name} from #{construction.name}. This surface will not have the standard applied.")
return previous_construction_map
end
# Exterior Doors
elsif surf_type == 'ExteriorDoor'
stds_type = standards_info.standardsConstructionType
if stds_type.is_initialized
stds_type = stds_type.get
case stds_type
when 'RollUp', 'Rollup', 'NonSwinging', 'Nonswinging'
stds_type = 'NonSwinging'
else
stds_type = 'Swinging'
end
else
OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.PlanarSurface', "Could not determine the standards construction type for exterior door #{planar_surface.name}. This door will not have the standard applied.")
return previous_construction_map
end
# All other surface types
else
stds_type = standards_info.standardsConstructionType
Expand Down