Feat/offshore lcp #150
Feat/offshore lcp #150
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #150 +/- ##
==========================================
- Coverage 82.55% 80.56% -2.00%
==========================================
Files 117 118 +1
Lines 12820 13225 +405
==========================================
+ Hits 10584 10655 +71
- Misses 2236 2570 +334
Flags with carried forward coverage won't be shown. Click here to find out more.
|
reVX/config/least_cost_xmission.py
Outdated
| self._name = self.get('name') | ||
| else: | ||
| # name defaults to base directory name | ||
| self._name = os.path.basename(os.path.normpath(self.dirout)) |
There was a problem hiding this comment.
you should do something like this:
default_name = os.path.basename(os.path.normpath(self.dirout))
self._name = self.get('name', default_name)
| @@ -0,0 +1,604 @@ | |||
| """ | |||
| Various utility functions to prep data for AOSWT processing. | |||
There was a problem hiding this comment.
Would this module not work for the pacific? Why not?
There was a problem hiding this comment.
Looks like Mike was in the process of working on this (see quote form him below), but the demand for this work dropped off. I propose to shelve this question until demand for this work arises once more
TODO:
- When saving paths, also export to CSV
- calculate % path distance offshore vs land and save to dist_offshore_frac column
- change README to rst
- remove AOSWT from naming when appropriate and make ocean agnostic
- Update linter config (done)
- Make 500kV default voltage for fake t-lines
There was a problem hiding this comment.
The AOSWT code would really work for determining paths anywhere within the reV raster, including on land.
There was a problem hiding this comment.
Should we rename the file?
There was a problem hiding this comment.
The code was written for AOSWT (Atlantic off-shore wind transmission) and has only been used for AOSWT so far. Naming it after it provides some history, assuming the user knows what AOSWT is. Keeping it named AOSWT until it's used for something else makes sense to me. That said, I won't be offended if you decide to change it.
| # Append some fake values to make the LCP code happy | ||
| lines['ac_cap'] = 9999999 | ||
| lines['category'] = 'Substation' | ||
| lines['voltage'] = 69 |
There was a problem hiding this comment.
maybe make the fake voltage 0 or 1e9?
There was a problem hiding this comment.
The substation needs a transmission line with adequate voltage for the code to connect to it. I arbitrarily chose 69kV as a standard voltage. 1e9 may work as well but I would need to check it.
| Combine layers to create composite friction and barrier rasters. Merge | ||
| with existing land cost and barriers and save to h5. | ||
| """ | ||
| OS_FRICTION_FNAME = 'os_friction.tif' |
There was a problem hiding this comment.
What is OS? Offshore? Onshore is also OS?
There was a problem hiding this comment.
Renamed to "Offshore" for clarity
| save_tiff : bool, optional | ||
| Save composite friction to tiff if true | ||
| """ | ||
| print('Loading friction layers') |
There was a problem hiding this comment.
Please convert all print statements to logger.info() statements
|
|
||
| def _load_layer(self, f, val, verbose=False): | ||
| """ | ||
| Load a layer from a tiff and set appropriate cells to 1 |
There was a problem hiding this comment.
Can you only handle tiff inputs? Should we support our collection of h5 exclusion layers?
There was a problem hiding this comment.
Does not seem to be major demand for this request, so I propose we shelve it. In the immediate future, anyone looking to use this function with an h5 exclusion layer can use the $ exclusions layers-from-h5 command line utility to extract h5 layers as tiff.
There was a problem hiding this comment.
A little context: I'm not very good at using h5s and I frequently load raster and vector data into QGIS for using basemaps and zooming. QGIS doesn't speak h5. Tiffs are also much smaller than h5 files and easier to copy to and from eagle. So that's why some of this code is setup for using tiffs. I believe all the input files have already been converted to h5 files. Switching over to a pure h5 workflow should not be an issue.
|
TODO:
|
|
@mikebannis Are there any plans to finalize this? I will be working on some changes to LCP next week, so I'd like to know if I need to work around this PR or not |
|
After conversation with Mike, I will attempt to do bare minimum to make this PR mergeable |
Not done yet and need to do a lot of linting. Just leaving this here as a heads up and to see if there are any grievous issues I need to fix.