Merge methods #154
Merge methods #154
Conversation
Codecov Report
@@ Coverage Diff @@
## main #154 +/- ##
==========================================
+ Coverage 80.59% 80.93% +0.33%
==========================================
Files 110 110
Lines 11974 12075 +101
==========================================
+ Hits 9651 9773 +122
+ Misses 2323 2302 -21
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| weights_calculation_upscale_factor=sf, | ||
| multiplier=100) | ||
| merged_layer = merged_setbacks.compute_setbacks(features_path, | ||
| max_workers=1) |
There was a problem hiding this comment.
I'm a little confused on where the actual merge request happens... Like you're not actually requesting a merge of two exclusion layers but instead just combining the setback distance input with an explicit regulations file? Otherwise looks good to me!
There was a problem hiding this comment.
Right, I think the title is a bit misleading (I essentially copied the issue request)
Anthony had said: "Either add a flag to handle all of this in one go e.g., model existing ordinances and apply [generic ordinances] elsewhere. Or have a new method that assumes you've already created the necessary datasets and just want to merge them (less ideal)."
He said the second option is less ideal so I went with the first idea (except there was no need for a new flag value)
There was a problem hiding this comment.
Merging this so that Anthony can start using it, but let me know if you have any other questions/objections!
Added support for merging existing and extrapolated ordinances in one
reVXinvocation.No new flag was needed - the user can now simply provide both a setback multiplier and a regulations file.
Sample comparisons shown below (with extreme cases to illustrate the functionality):