Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setbacks bug fixes #156

Merged
merged 8 commits into from
Jul 15, 2022
Merged

Setbacks bug fixes #156

merged 8 commits into from
Jul 15, 2022

Conversation

ppinchuk
Copy link
Collaborator

@ppinchuk ppinchuk commented Jul 7, 2022

PR to fix the numerous bugs found while attempting to run parcel setbacks for bespoke.

@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2022

Codecov Report

Merging #156 (51fc675) into main (922e71e) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
+ Coverage   81.04%   81.08%   +0.03%     
==========================================
  Files         110      110              
  Lines       12142    12172      +30     
==========================================
+ Hits         9841     9870      +29     
- Misses       2301     2302       +1     
Flag Coverage Δ
unittests 81.08% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
reVX/setbacks/base.py 89.75% <100.00%> (+0.22%) ⬆️
tests/test_setbacks.py 99.31% <100.00%> (+0.03%) ⬆️
reVX/handlers/database.py 0.00% <0.00%> (ø)
reVX/rpm/rpm_clusters.py 80.60% <0.00%> (+0.08%) ⬆️
reVX/plexos/plexos_plants.py 55.04% <0.00%> (+0.09%) ⬆️

@ppinchuk
Copy link
Collaborator Author

Going to merge this as it needs to be used - we can discuss any issues later

@ppinchuk ppinchuk merged commit 2dd3de5 into main Jul 15, 2022
@ppinchuk ppinchuk deleted the pp/setback_bug_fixes branch July 15, 2022 19:19
github-actions bot pushed a commit that referenced this pull request Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants