added option for explicit rpm cluster CRS with default to WGS 84 #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppinchuk
previously approved these changes
Dec 20, 2022
reVX/rpm/rpm_clusters.py
Outdated
| crs="EPSG:5070") | ||
| crs=source_crs) | ||
|
|
||
| if target_crs is not None: |
There was a problem hiding this comment.
Do you know if Geopandas efficiently handles the case where the df crs == target crs? If we want to be extra cautious, we could change this to if target_crs != source_crs: in order to be completely sure that no unnecessary computation is happening
There was a problem hiding this comment.
No idea haha that's a good idea to add that!
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #168 +/- ##
==========================================
- Coverage 80.64% 80.62% -0.03%
==========================================
Files 118 118
Lines 13317 13324 +7
==========================================
+ Hits 10740 10742 +2
- Misses 2577 2582 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
grantbuster
force-pushed
the
gb/rpm_crs
branch
from
48d87ac
to
928f327
Compare
ppinchuk
approved these changes
Dec 21, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Dec 22, 2022
added option for explicit rpm cluster CRS with default to WGS 84
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.