Minor reeds col update #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@grantbuster This change is so minor that I might just merge it in once all tests are done |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #183 +/- ##
=======================================
Coverage 81.32% 81.32%
=======================================
Files 113 113
Lines 13332 13339 +7
=======================================
+ Hits 10842 10848 +6
- Misses 2490 2491 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
github-actions bot
pushed a commit
that referenced
this pull request
Jun 6, 2023
Minor reeds col update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow rename mapping to happen before addition of
eos_mult,reg_mult. These columns are expected by ReEDS and users shouldn't be renaming them anyways. On the flip side, it's entirely possible to rename a column into one of these, so this order makes a lot more logical sense.