-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LCP QOL updates #198
Merged
Merged
LCP QOL updates #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #198 +/- ##
==========================================
+ Coverage 80.47% 80.54% +0.06%
==========================================
Files 114 114
Lines 13619 13678 +59
==========================================
+ Hits 10960 11017 +57
- Misses 2659 2661 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mikebannis
previously approved these changes
Oct 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add logic to submit futures in chunks of
max_workers
for LCP calculations. This ensures that user can control the memory consumption of the LCP computation by settingmax_workers
(i.e. futures that don't start processing right away won't eat up a whole node's worth of memory during submission). No new tests required for this change, since we had tests for parallel LCP computation already.Also a added a
clip_buffer
option to address a very minor bug where the LCP sometimes cannot be found if the clipping process creates islands. The new tests demonstrates this instance.Also fixes HOPP dependency that breaks our tests by pinning HOPP version