Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCP QOL updates #198

Merged
merged 15 commits into from
Nov 6, 2023
Merged

LCP QOL updates #198

merged 15 commits into from
Nov 6, 2023

Conversation

ppinchuk
Copy link
Collaborator

@ppinchuk ppinchuk commented Sep 27, 2023

Add logic to submit futures in chunks of max_workers for LCP calculations. This ensures that user can control the memory consumption of the LCP computation by setting max_workers (i.e. futures that don't start processing right away won't eat up a whole node's worth of memory during submission). No new tests required for this change, since we had tests for parallel LCP computation already.

Also a added a clip_buffer option to address a very minor bug where the LCP sometimes cannot be found if the clipping process creates islands. The new tests demonstrates this instance.

Also fixes HOPP dependency that breaks our tests by pinning HOPP version

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2023

Codecov Report

Merging #198 (f2e393e) into main (2dd0540) will increase coverage by 0.06%.
Report is 1 commits behind head on main.
The diff coverage is 96.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #198      +/-   ##
==========================================
+ Coverage   80.47%   80.54%   +0.06%     
==========================================
  Files         114      114              
  Lines       13619    13678      +59     
==========================================
+ Hits        10960    11017      +57     
- Misses       2659     2661       +2     
Flag Coverage Δ
unittests 80.54% <96.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
reVX/least_cost_xmission/least_cost_paths.py 97.90% <100.00%> (+0.10%) ⬆️
reVX/least_cost_xmission/least_cost_paths_cli.py 74.70% <100.00%> (+0.30%) ⬆️
reVX/least_cost_xmission/least_cost_xmission.py 89.58% <100.00%> (+0.37%) ⬆️
...eVX/least_cost_xmission/least_cost_xmission_cli.py 50.00% <ø> (ø)
tests/test_xmission_least_cost_paths.py 96.66% <100.00%> (+0.44%) ⬆️
reVX/config/least_cost_xmission.py 80.58% <50.00%> (-0.62%) ⬇️

... and 7 files with indirect coverage changes

mikebannis
mikebannis previously approved these changes Oct 5, 2023
Copy link
Collaborator

@mikebannis mikebannis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ppinchuk ppinchuk merged commit 820c81e into main Nov 6, 2023
8 checks passed
@ppinchuk ppinchuk deleted the pp/lcp_qol branch November 6, 2023 20:50
github-actions bot pushed a commit that referenced this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants