Fix(PlexosAggregation): Adding missing parameter to select different column for the "sc_gid" #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
methods. I forgot to propagate the changes of the custom gid_column. It did not broke before since it was falling back to "sc_gid", but currently we are using "sc_point_gid"
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## gb/plexos_bespoke #200 +/- ##
====================================================
Coverage ? 76.86%
====================================================
Files ? 114
Lines ? 13662
Branches ? 0
====================================================
Hits ? 10501
Misses ? 3161
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. |
grantbuster
approved these changes
Nov 13, 2023
When we apply the map it endup creating two columns with the same name. An example of this is the solar supply curve have both capacity_mw_ac and capacity. This should fix this problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to propagate the changes of the custom gid_column for the rest of the methods. It did not broke before since it was falling back to "sc_gid", but currently we are using “sc_point_gid”. This PR just add it as an optional argument in all the places that gets used.