Mjb/feat/osw generate landfall costs #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikebannis
force-pushed
the
mjb/feat/osw-generate-landfall-costs
branch
from
840bac6
to
f36f019
Compare
mikebannis
force-pushed
the
mjb/feat/osw-generate-landfall-costs
branch
from
f36f019
to
4790c1c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #201 +/- ##
==========================================
+ Coverage 76.75% 80.98% +4.23%
==========================================
Files 114 124 +10
Lines 13692 14059 +367
==========================================
+ Hits 10509 11386 +877
+ Misses 3183 2673 -510
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mikebannis
force-pushed
the
mjb/feat/osw-generate-landfall-costs
branch
from
faf931d
to
16d5b70
Compare
mikebannis
force-pushed
the
mjb/feat/osw-generate-landfall-costs
branch
2 times, most recently
from
3d3cf18
to
44d4e30
Compare
mikebannis
force-pushed
the
mjb/feat/osw-generate-landfall-costs
branch
from
44d4e30
to
c511d97
Compare
mikebannis
force-pushed
the
mjb/feat/osw-generate-landfall-costs
branch
from
49d2c5d
to
72b1af4
Compare
mikebannis
force-pushed
the
mjb/feat/osw-generate-landfall-costs
branch
from
db9f1d0
to
8183cd5
Compare
…osts' into pp/doc_updates
Doc updates for new transmission code
ppinchuk
requested changes
Feb 2, 2024
There was a problem hiding this comment.
Whew, this was a big one! Great job on this. I especially love all the composition - makes tests easier and honestly the code looks better too! We need to get better about using some of these design principles on the reV team, so good job pushing that forward.
Threw some comments below, mostly about leftover TODO's and missing exceptions? I feel like the latter may have been intentional but I don't understand why, so def let me know what your thought process there was. I may be way off base.
mikebannis
commented
Feb 2, 2024
…L/reVX into mjb/feat/osw-generate-landfall-costs
ppinchuk
reviewed
Feb 2, 2024
ppinchuk
approved these changes
Feb 4, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Feb 5, 2024
* Add method to rasterize vectors into cost layers * Build cost raster using bins * Combine cost rasters and optional barrier normalization * Start OffshoreCostCreator * Update tests * Merge offshore and land costs * Merge barriers with new masks & chunk h5 * Allow default value to be set when reprojecting rasters * progress converting to new offshore system * user standardized tiff load func * Basic friction/barrier buildign * combine friction/barrier layers * Start on new trans cost/fric/barrier CLI * cost combiner for wet and dry costs * Update doc strings * Update logger statements * Remove old code * Fix test * Refactor and pylint updates * Use chunks for h5, save profile in attrs * Mask dir in JSON file does not need to exist * fric/barrier processing optimizations * reproject tiff layers on load if needed * Allow multiple ranges for same TIFF file * update setup.py and requirements.txt * Reorganize xmission directory * Update pylintrc * Update README * Start updating README * combine friction and barriers before loading into h5 * Update config actions * Replace TypedDicts with pydantic.BaseModel * Allow forced inclusions to be used * minor clean up * Remove xmission example notebooks * Update layer creation README * More xmission README updates * Move mask creation to a CLI option * CLI flag to allow unknown keys in config file * Added missing init file for sphinx to catch the dir * move h5 creation to CLI optoin * Fix docstrings that throw error * Add hard links instead of relative for Sphinx * Add transmission to exmaples docs * Add docs for new clis * move h5 creation to CLI option * Add docs to pydantic model keys * Fix merge bugs * Formatting + docstring updates * Linter fix * Various PR style updates and refactors * Remove unnecessary TODO * Use unified RangeConfig class for barriers and costs * Update README for RangeConfig change --------- Co-authored-by: ppinchuk <ppinchuk@nrel.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create landfall costs from raster and per cell costs by binning bathymetric depth. Also compute costs/friction/barriers for both dry and wet areas. Near full rewrite of layer creation code.