Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor LCP fixes #220

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Minor LCP fixes #220

merged 2 commits into from
Jun 7, 2024

Conversation

ppinchuk
Copy link
Collaborator

@ppinchuk ppinchuk commented Jun 7, 2024

Drop NA category from features and new default barrier name in config for concistency

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.70%. Comparing base (13fc8e8) to head (5145a1e).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #220      +/-   ##
==========================================
- Coverage   82.72%   82.70%   -0.03%     
==========================================
  Files         118      118              
  Lines       14448    14454       +6     
==========================================
+ Hits        11952    11954       +2     
- Misses       2496     2500       +4     
Flag Coverage Δ
unittests 82.70% <55.55%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
reVX/config/transmission_layer_creation.py 100.00% <100.00%> (ø)
reVX/least_cost_xmission/least_cost_xmission.py 89.03% <33.33%> (-0.91%) ⬇️

@ppinchuk ppinchuk merged commit 5c2b150 into main Jun 7, 2024
8 checks passed
@ppinchuk ppinchuk deleted the pp/minor_fixes branch June 7, 2024 06:15
github-actions bot pushed a commit that referenced this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants