Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heat pump controls #1179

Closed
wants to merge 10 commits into from
Closed

Heat pump controls #1179

wants to merge 10 commits into from

Conversation

joseph-robertson
Copy link
Contributor

Pull Request Description

Addresses #1154.
Tests NREL/OpenStudio-HPXML#1547.

Checklist

Not all may apply:

  • Tests (and test files) have been updated
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected regression test changes on CI (checked comparison artifacts)

…79a74ac

f2ae179a74ac Merge branch 'master' into max-airflow-args
438ad8b58a57 Merge pull request #1567 from NREL/fix_allow_increased_fixed_capacities
f19751133b70 Update Changelog.md [ci skip]
1843fe5e448d Fixes error if using AllowIncreasedFixedCapacities=true w/ HP detailed performance data.
a77a6e575327 Merge pull request #1566 from NREL/low_cooling_shr
6a272b2e34a3 Error-checking for unrealistically low HVAC SensibleHeatFraction values (less than or equal to 0.5).
43bd6eec4887 Merge pull request #1563 from NREL/remove_sizing_method
c2b3177bf2f7 Method was deprecated in NREL/OpenStudio-HPXML@b2b89b8.
8b3979ba1f54 Latest results.
c1f802ac386a Update the docs.
8e27f7ce815d Move fan adjust bool to heat pump, update schematron, add sample file.
75f3797aaaae Fix the docs.
ce762cf93a80 Begin to add airflow cfm fields to docs.
44a7f2c6b887 Latest results.
0aaa5dd47c3f Skip max-airflow hvac_configuration test for now.
4cb9e587be04 Write new methods for hvac_sizing.
1beb3691411e Merge branch 'watts-per-cfm-args' into max-airflow-args
a7b2f89d3a16 Merge branch 'master' into watts-per-cfm-args
31a36babbb05 Latest results.
522f1819ae6f Forgot to actually set the new arg value.
ee6abb726eee Add bool arg for fan efficiency adjustment.
fdb5f16f79b5 Latest results.
4e6438e7a197 Merge branch 'watts-per-cfm-args' into max-airflow-args
35634487355b Update hpxml inputs json after merge.
69518743ec25 Merge branch 'watts-per-cfm-args' into max-airflow-args
31c271c90d09 Merge branch 'master' into watts-per-cfm-args
2551567f137a Latest results.
7ffc8206ae92 Forgot to default the new bool arg.
6d59d3257ce6 Switch from new methodology to just an input, and write a test.
a6dcec067af1 Use airflow max method.
a134d7fbd88a For now, test using a new sample file.
fc2836ec1317 Update defaults for fan adjustment and airflow maximums.
e2d50c8b8397 Update epvalidator for new hp sizing methodology enum.
49f9ba2bea97 Add new hp sizing methodology, and args for airflow rates.
03371101b8d7 Merge branch 'master' into watts-per-cfm-args
44b6e2730a22 Merge branch 'master' into watts-per-cfm-args
c6f30fa3eeff Collapse new args into a single one since only a single air distribution system is supported.
41c6cee061cc Regenerate the BuildResHPXML readme file.
5af4e6167bcf Replace tasks.rb mods with hpxml_inputs.json updates.
f43e85faf8c3 Add optional blower fan efficiency args to BuildResHPXML.

git-subtree-dir: resources/hpxml-measures
git-subtree-split: f2ae179a74acc106b04aabb14808ed3c17ed517a
…6900a11

383036900a11 Set capacity to the max?

git-subtree-dir: resources/hpxml-measures
git-subtree-split: 383036900a11f92f28fddd8ed8887271c9d9f5e2
@joseph-robertson
Copy link
Contributor Author

joseph-robertson commented Dec 8, 2023

$ /c/openstudio-3.7.0/bin/openstudio.exe workflow/run_analysis.rb -y project_national/hp_upgrades.yml -o -i 61

hp_controls_id61.xlsx

Questions:

  • Only adjust the fan W/cfm if the max of the heating/cooling airflow in the upgrade case is smaller than the max of the heating/cooling airflow in the baseline case? Otherwise, it seems like fan W/cfm increases.
  • When using max allowed heating/cooling airflow, proportionally adjust heating/cooling capacities independently? Then set heating/cooling capacity to the max of the two values?

@joseph-robertson joseph-robertson mentioned this pull request Jan 24, 2024
6 tasks
@joseph-robertson joseph-robertson deleted the max-airflow-args branch January 24, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant