Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HVAC Autosizing Limits #1197

Draft
wants to merge 134 commits into
base: develop
Choose a base branch
from
Draft

HVAC Autosizing Limits #1197

wants to merge 134 commits into from

Conversation

joseph-robertson
Copy link
Contributor

@joseph-robertson joseph-robertson commented Jan 24, 2024 •
edited
Loading

Pull Request Description

Addresses #1154.
Tests NREL/OpenStudio-HPXML#1584 and NREL/OpenStudio-HPXML#1558.
Supersedes #1179.

Add sample files:

  • national_upgrades_HPs_TMY3.yml and national_upgrades_HPs_AMY2018.yml
    • Case 1: Baseline Stock - TMY3
    • Case 2: Baseline Upgrade - EnergyStar Heat Pump, Existing System Backup
    • Case 3: Baseline Upgrade - EnergyStar Heat Pump, Electric Backup
    • Case 7: Heat Pump Selection – EnergyStar Mid Efficiency, Electric Backup
    • Case 8: Heat Pump Selection – Typical Cold Climate
    • Case 9: Heat Pump Selection – High COP, Cold-Temperature
    • Case 10: Heat Pump Selection – High COP, Part Load
    • Case 11: Heat Pump Selection – High Capacity, Cold Temperature
    • Case 12: Heat Pump Selection - TBD
    • Case 13: Heat Pump Selection - TBD
    • Case 14: Heat Pump Sizing – Typical Cold Climate (Case 8)
      • A
        • Ducted: 25% between Autosize Limit and MaxLoad
        • Ductless: 25% between ACCA and MaxLoad
      • B
        • Ducted: 50%
        • Ductless: 50%
      • C
        • Ducted: MaxLoad
        • Ductless: ACCA
      • D
        • Ducted: ACCA
        • Ductless: skip
    • Case 15: Heat Pump Sizing - EnergyStar Heat Pump, Electric Backup (Case 3)
      • A
        • Ducted: 25% between Autosize Limit and MaxLoad
        • Ductless: 25% between ACCA and MaxLoad
      • B
        • Ducted: 50%
        • Ductless: 50%
      • C
        • Ducted: MaxLoad
        • Ductless: ACCA
      • D
        • Ducted: ACCA
        • Ductless: skip

Add cost multipliers:

  • upgrade_costs.air_flow_rate_heating_system_primary_cfm
  • upgrade_costs.air_flow_rate_heating_system_secondary_cfm
  • upgrade_costs.air_flow_rate_cooling_system_primary_cfm
  • upgrade_costs.air_flow_rate_heat_pump_backup_primary_cfm

Checklist

Not all may apply:

  • Tests (and test files) have been updated
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected regression test changes on CI (checked comparison artifacts)

@joseph-robertson
Squashed 'resources/hpxml-measures/' changes from 9d6504d6c39..b5a360…
0fddc09 
…8ccd3

b5a3608ccd3 Latest results.
12ff3684fbc Fix typo.
022fb2723c8 Remove rule from epvalidator and instead max takes precedence.
8ec19a9aeaa Remove new hvac sizing test now that it is replaced in default tests.
7dfe1666df1 Update schematron and add test.
cd85f959a9a Update build measure argument descriptions.
fd7261677f4 Fix docs tables.
cd1d3cd8626 Merge branch 'master' into max-airflow-args2
fab1e24cd48 Replace high-level restriction input with optiona max airflow args.
d6fac4f185a Fix bug in new method and update tests.
5201bca29f7 Ignore OS message.
0d2ad4c32e6 Merge pull request #1590 from NREL/revert_xmlvalidator
5e0f974989b Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into revert_xmlvalidator
546f504c90f Merge branch 'master' into max-airflow-args2
9b023438f93 Merge branch 'max-airflow-args2' of github.com:NREL/OpenStudio-HPXML into max-airflow-args2
9b2e5ae8d47 Start adding ductwork restriction tests for various system types.
451001898c7 Merge pull request #1589 from NREL/flatten_documentation
7cb579f0372 Some cleanup/fixes.
66619ec8299 Latest results.
6e60e7662b9 Update default tests with airflow checks.
612c71105d6 Update test.
9d22e625c04 Update BuildResHPXML measure links.
188a92825c1 Handle hot water distribution [ci skip]
53249533f4f Handle solar thermal [ci skip]
c482b8eb413 Use consistent language [ci skip]
ec645b9a5ed Handle ventilation fans. [ci skip]
32f2f2c5678 Address HVAC distribution [ci skip]
5305dbff27e Address water heaters. [ci skip]
a8a9034caf6 Clean up code in new method.
24f61d9de6a Merge branch 'master' into max-airflow-args2
80c4a2586a6 Address heat pumps [ci skip]
d0319bff915 Merge branch 'master' into max-airflow-args2
deacd79d179 Few comment updates.
1c83895eb83 Update measure.xml [ci skip]
72929792871 Try reverting XMLValidator workaround for NREL/OpenStudio#4824.
b9b2eef38b1 Flatten HVAC heating and cooling systems. [ci skip]
57dd48445ca Collapse airflow and fan adjustment into one.
184154e3c4d Merge branch 'master' into max-airflow-args
04c57c7c68e Latest results.
2b1714b99aa For now only apply fan adjustment to HP.
516e4efdbf1 Update fan adjustment and max airflow test expected values.
1a6bd6c2210 Update max_airflows method based on comments.
17ad82f65a8 Merge branch 'master' into max-airflow-args
cc8c13a1fa5 Switch v_baseline with v_upgrade, and add a commented question.
383036900a1 Set capacity to the max?
f2ae179a74a Merge branch 'master' into max-airflow-args
8b3979ba1f5 Latest results.
c1f802ac386 Update the docs.
8e27f7ce815 Move fan adjust bool to heat pump, update schematron, add sample file.
75f3797aaaa Fix the docs.
ce762cf93a8 Begin to add airflow cfm fields to docs.
44a7f2c6b88 Latest results.
0aaa5dd47c3 Skip max-airflow hvac_configuration test for now.
4cb9e587be0 Write new methods for hvac_sizing.
1beb3691411 Merge branch 'watts-per-cfm-args' into max-airflow-args
a7b2f89d3a1 Merge branch 'master' into watts-per-cfm-args
31a36babbb0 Latest results.
522f1819ae6 Forgot to actually set the new arg value.
ee6abb726ee Add bool arg for fan efficiency adjustment.
fdb5f16f79b Latest results.
4e6438e7a19 Merge branch 'watts-per-cfm-args' into max-airflow-args
35634487355 Update hpxml inputs json after merge.
69518743ec2 Merge branch 'watts-per-cfm-args' into max-airflow-args
31c271c90d0 Merge branch 'master' into watts-per-cfm-args
2551567f137 Latest results.
7ffc8206ae9 Forgot to default the new bool arg.
6d59d3257ce Switch from new methodology to just an input, and write a test.
a6dcec067af Use airflow max method.
a134d7fbd88 For now, test using a new sample file.
fc2836ec131 Update defaults for fan adjustment and airflow maximums.
e2d50c8b839 Update epvalidator for new hp sizing methodology enum.
49f9ba2bea9 Add new hp sizing methodology, and args for airflow rates.
03371101b8d Merge branch 'master' into watts-per-cfm-args
44b6e2730a2 Merge branch 'master' into watts-per-cfm-args
c6f30fa3eef Collapse new args into a single one since only a single air distribution system is supported.
41c6cee061c Regenerate the BuildResHPXML readme file.
5af4e6167bc Replace tasks.rb mods with hpxml_inputs.json updates.
f43e85faf8c Add optional blower fan efficiency args to BuildResHPXML.

git-subtree-dir: resources/hpxml-measures
git-subtree-split: b5a3608ccd38db6c63db560801d5de16ecdea791
@joseph-robertson
Merge commit '0fddc0901306dfe019835e9cecb29bc679724648' into max-airf…
346d1c0 
…low-args2
@joseph-robertson
Assign existing airflows in applyupgrade measure.
121df3d
@joseph-robertson
New bool resstockarguments argument for ductwork restriction.
8fb8235
@joseph-robertson
Update upgrade ymls with ductwork restriction options.
599802b
@joseph-robertson
Update lookup with new ductwork restriction option.
01f0004
@joseph-robertson joseph-robertson self-assigned this Jan 24, 2024
@joseph-robertson
Copy link
Contributor Author

Create a new test yml file with the following upgrade scenarios:

  • ASHP to homes that are ducted
  • MSHP to homes that are not ducted

@joseph-robertson joseph-robertson mentioned this pull request Feb 8, 2024
Closed
6 tasks
joseph-robertson and others added 10 commits February 8, 2024 12:40
@joseph-robertson
Merge branch 'develop' into max-airflow-args2
59a15c6
@joseph-robertson
Squashed 'resources/hpxml-measures/' changes from 4f60b2e19cb..b42623…
b244a0d 
…2a2d9

b426232a2d9 Latest results.
392c416092d Remove comment in test.
ebb62f68aa1 Handle ductwork restriction case in hvac configurations test.
5838282cf0b Merge branch 'master' into max-airflow-args2
87b63bfbec9 Merge pull request #1605 from NREL/pipe_lengths
d65f73faf87 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into pipe_lengths
1013d3375fb Merge pull request #1608 from NREL/vshp_min_compessor_temp
a7eb0f84300 Latest results.
4172da621e6 Now defaults to -20F for `CompressorLockoutTemperature` for variable-speed air-to-air heat pumps. Consistent with mini-split heat pumps.
ac2ac083c29 Fix repeated text in docs, update another spot where pipe length calculation gets called.
39ba2b272e7 Missed a spot where standard pipe lengths are calculated
189871c2dfd update Changelog.md, rubocop
1c973d68937 Fix edge cases with both conditioned and unconditioned basements
8d9473cba03 Merge branch 'master' into max-airflow-args2
b5a3608ccd3 Latest results.
12ff3684fbc Fix typo.
022fb2723c8 Remove rule from epvalidator and instead max takes precedence.
8ec19a9aeaa Remove new hvac sizing test now that it is replaced in default tests.
7dfe1666df1 Update schematron and add test.
cd85f959a9a Update build measure argument descriptions.
fd7261677f4 Fix docs tables.
cd1d3cd8626 Merge branch 'master' into max-airflow-args2
fab1e24cd48 Replace high-level restriction input with optiona max airflow args.
d6fac4f185a Fix bug in new method and update tests.
546f504c90f Merge branch 'master' into max-airflow-args2
9b023438f93 Merge branch 'max-airflow-args2' of github.com:NREL/OpenStudio-HPXML into max-airflow-args2
9b2e5ae8d47 Start adding ductwork restriction tests for various system types.
66619ec8299 Latest results.
6e60e7662b9 Update default tests with airflow checks.
a8a9034caf6 Clean up code in new method.
24f61d9de6a Merge branch 'master' into max-airflow-args2
d0319bff915 Merge branch 'master' into max-airflow-args2
deacd79d179 Few comment updates.
57dd48445ca Collapse airflow and fan adjustment into one.
184154e3c4d Merge branch 'master' into max-airflow-args
04c57c7c68e Latest results.
2b1714b99aa For now only apply fan adjustment to HP.
516e4efdbf1 Update fan adjustment and max airflow test expected values.
1a6bd6c2210 Update max_airflows method based on comments.
17ad82f65a8 Merge branch 'master' into max-airflow-args
cc8c13a1fa5 Switch v_baseline with v_upgrade, and add a commented question.
383036900a1 Set capacity to the max?
f2ae179a74a Merge branch 'master' into max-airflow-args
8b3979ba1f5 Latest results.
c1f802ac386 Update the docs.
8e27f7ce815 Move fan adjust bool to heat pump, update schematron, add sample file.
75f3797aaaa Fix the docs.
ce762cf93a8 Begin to add airflow cfm fields to docs.
44a7f2c6b88 Latest results.
0aaa5dd47c3 Skip max-airflow hvac_configuration test for now.
4cb9e587be0 Write new methods for hvac_sizing.
1beb3691411 Merge branch 'watts-per-cfm-args' into max-airflow-args
a7b2f89d3a1 Merge branch 'master' into watts-per-cfm-args
31a36babbb0 Latest results.
522f1819ae6 Forgot to actually set the new arg value.
ee6abb726ee Add bool arg for fan efficiency adjustment.
fdb5f16f79b Latest results.
4e6438e7a19 Merge branch 'watts-per-cfm-args' into max-airflow-args
35634487355 Update hpxml inputs json after merge.
69518743ec2 Merge branch 'watts-per-cfm-args' into max-airflow-args
31c271c90d0 Merge branch 'master' into watts-per-cfm-args
2551567f137 Latest results.
7ffc8206ae9 Forgot to default the new bool arg.
6d59d3257ce Switch from new methodology to just an input, and write a test.
a6dcec067af Use airflow max method.
a134d7fbd88 For now, test using a new sample file.
fc2836ec131 Update defaults for fan adjustment and airflow maximums.
e2d50c8b839 Update epvalidator for new hp sizing methodology enum.
49f9ba2bea9 Add new hp sizing methodology, and args for airflow rates.
03371101b8d Merge branch 'master' into watts-per-cfm-args
44b6e2730a2 Merge branch 'master' into watts-per-cfm-args
c6f30fa3eef Collapse new args into a single one since only a single air distribution system is supported.
41c6cee061c Regenerate the BuildResHPXML readme file.
5af4e6167bc Replace tasks.rb mods with hpxml_inputs.json updates.
f43e85faf8c Add optional blower fan efficiency args to BuildResHPXML.

git-subtree-dir: resources/hpxml-measures
git-subtree-split: b426232a2d9014dcb69ba0043d72ad83d12fe692
@joseph-robertson
Merge commit 'b244a0db8e29062546de5dc5ea276def4adf7dc7' into max-airf…
4b04d07 
…low-args2
@joseph-robertson
Change name of yml output folder.
dc7c83d
Latest results.
af3fdc5
@joseph-robertson
Merge branch 'develop' into max-airflow-args2
13fe54c
@joseph-robertson
Assign airflows when air distribution type.
4791f6a
@joseph-robertson
Add airflow cfm cost multiplers.
8fc3db4
@joseph-robertson
Update outputs data dictionary.
71eeb89
Latest results.
7209f79
whiphi92 and others added 30 commits July 31, 2024 09:35
@whiphi92
timeseries change
641dfa0
@joseph-robertson
Revert bad changes to lookup.
7b9a6fc
@joseph-robertson
Revert more changes to lookup.
3632a1f
@joseph-robertson
Fix typo in lookup.
02ad230
Latest results.
bd71554
@joseph-robertson
Some updates and fixes in new air distribution methods.
a0abdd8
Latest results.
0975444
@joseph-robertson
Missing .nil? in refactored method.
497fcd5
@joseph-robertson
Minor updates to yml files.
5852720
Latest results.
7c0aee2
@joseph-robertson
Minor updates to yml files. [ci skip]
c67bedf
kestrel 30k run yml files
ff263ab
@joseph-robertson
Add Case 3 and 8 ACCA options to lookup.
ed886f0
@joseph-robertson
Update ymls for Case 14d and 15a-d.
1023f61
kestrel-fying the 30k run ymls
06a9236
Merge branch 'max-airflow-args2' of https://github.com/NREL/resstock …
f5256e0 
…into max-airflow-args2
@joseph-robertson
Merge branch 'develop' into max-airflow-args2
d0bfa86
@joseph-robertson
Use frac load served for autosize limit calculation.
d217bea
Latest results.
f1e213e
@joseph-robertson
Merge branch 'develop' into max-airflow-args2
1a4f19f
Latest results.
5517fce
@joseph-robertson
Update ApplyUpgrade to avoid averaging inverted setpoints when upgrad…
a729a95 
…e adds heating or cooling.
Latest results.
8ed5109
yml updates
3103778
switchover ducts ymls
50ee198
switchover change
276a4c0
Latest results.
d75bd9e
edited ymls, duct leakage is commented out
4103f18
Merge branch 'max-airflow-args2' of https://github.com/NREL/resstock …
bfe8922 
…into max-airflow-args2
@joseph-robertson
Register a warning when there is no valid existing heating system for…
b10f219 
… heat pump backup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonwinkler jonwinkler jonwinkler left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@joseph-robertson joseph-robertson

Labels
DO NOT MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joseph-robertson @jonwinkler @whiphi92