Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geospatial #416

Merged
merged 11 commits into from
Mar 2, 2020
Merged

Geospatial #416

merged 11 commits into from
Mar 2, 2020

Conversation

afontani
Copy link
Contributor

@afontani afontani commented Feb 26, 2020 •
edited
Loading

Fixes #415.

Pull Request Description

This pull request is aimed at adding some spatial specification of ResStock samples. Currently, there are only two spatial descriptions in the housing characteristics: 1) Location (the epw weather file regions), and 2) Location Region (RECS defined Custom Regions) This pull request creates 10 housing characteristic files that help spatially define the location of a sampled housing unit.

New or updated spatial housing characteristics

Data for these characteristics are based on the American Community Survey (ACS) 5-year 2016 tables B25001 and B25004. Unit counts and vacant unit counts are specified at the census tract level. The distributions are based on the occupied unit counts (table B25001 minus table B25004).

  1. ASHRAE IECC Climate Zone 2004.tsv
  2. State.tsv
  3. County.tsv
  4. PUMA.tsv
  5. Census Division.tsv
  6. Census Region.tsv.tsv
  7. Location Region.tsv
  8. Building America Climate Zone.tsv
  9. Location.tsv
  10. ISO RTO Region.tsv

Based on these new spatial specifications, PUMS data is used to provide more granular distributions of certain housing characteristics.

Housing Characteristics Updated with the Public Use Microdata Sample (PUMS)

The following housing characteristics have been updated using 2017 PUMS.

  1. Geometry Building Type ACS
  2. Geometry Building Type RECS
  3. Heating Fuel
  4. Vintage ACS
  5. Vintage

The creation of all housing characteristics has been automated by tsv_maker classes. Supporting data has been uploaded to s3.

Checklist

Not all may apply:

  • Unit tests have been added or updated
  • All rake tasks have been run, and pass
  • Documentation has been modified appropriately
  • Any new options are added to project_testing
  • project_testing runs without any failures
  • No unexpected regression test changes
  • All tests are passing (green) on circleci
  • The changelog has been updated appropriately
  • This branch is up-to-date with master

For more information on how to perform these checklist items, see the documentation's Advanced Tutorial.

@afontani
Remove CA_Barstow.Daggett.AP.723815 from dependant housing characteri…
5f3f595 
…stics.

After the respecification of Location based on county. CA_Barstow.Daggett.AP.723815 no longer has any units assigned to this weather station. This is due to the population centroid of San Bernardino County being close to the Los Angeles metro area, so the Long Beach location is assigned to San Bernadino County.
@afontani
Adding new options for the geospatial tagging of samples.
1952a98
@afontani
Adding housing characteristics from the spatial and PUMS tsv_makers.
85ebca9
@afontani
Removing Geometry Unit Stories MF/SF from the housing characteristics…
ca0c9dc 
… and options_lookup.tsv

Addressing issue #415 as these characteristics do not assign any measure arguments, have no dependents, and conflict with Geometry Stories.
@afontani
Update CHANGELOG.md for the geospatial pull request.
0953029
@afontani afontani mentioned this pull request Feb 26, 2020
Closed
10 tasks
@afontani afontani self-assigned this Feb 26, 2020
joseph-robertson
joseph-robertson reviewed Feb 27, 2020
View reviewed changes
Copy link
Contributor

@joseph-robertson joseph-robertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might add as a fix in the changelog that Geometry Unit Stories has been removed.

I thought you were going to remove Geometry Building Type ACS from the testing project?

CHANGELOG.md Outdated Show resolved Hide resolved
@afontani afontani assigned ejhw and unassigned ejhw Mar 2, 2020
@afontani afontani requested a review from ejhw March 2, 2020 15:40
ejhw
ejhw approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@ejhw ejhw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Couple minor comments.

CHANGELOG.md Outdated Show resolved Hide resolved
project_multifamily_beta/housing_characteristics/ASHRAE IECC Climate Zone 2004.tsv Show resolved Hide resolved
project_multifamily_beta/housing_characteristics/Census Region.tsv
@@ -0,0 +1,11 @@
Dependency=Census Division Option=Midwest Option=Northeast Option=South Option=West sample_count sample_weight
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Census Region actually used for anything?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dep graph shows no

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct. Census Region is not being used for anything but is included for aggregation purposes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like an uncommon aggregation to me. I'd advocate removing it just for results.csv file size reasons, but ok if you want to leave it.

project_multifamily_beta/housing_characteristics/Cooling Setpoint Has Offset.tsv Show resolved Hide resolved
project_multifamily_beta/housing_characteristics/Vintage ACS.tsv Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@afontani afontani merged commit 747fa4e into master Mar 2, 2020
@afontani afontani deleted the geospatial branch March 2, 2020 23:35
@afontani afontani mentioned this pull request Mar 12, 2020
Closed
joseph-robertson added a commit that referenced this pull request Jun 15, 2020
@joseph-robertson
Squashed 'resources/hpxml-measures/' changes from abe59f87e2..dc012fbc3b
f84166d 
dc012fbc3b Add roof material and wall siding type arguments.
43d3cf10d8 Add back in geometry, constants methods.
915adb5889 Merge branch 'master' into build-res-hpxml-v3
5f671d70e1 Fix some class names.
357296ca42 Use compact dishwasher in test file.
b9cfb83b3f Merge pull request #390 from NREL/hvac_sizing_refactor
fd9293e476 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_sizing_refactor
671fc5b4f0 Merge pull request #375 from NREL/wh_refactor
08f5e6c242 Oops, not for combi systems.
5ea7fd14f0 Pull code back out of hpxml_defaults.rb.
b2576b2b6c Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into wh_refactor
0caa2761ef Normalize the crankcase power by the fraction load served. If there’s a single system, it will behave as before; if there are multiple systems, it will scale down (by the fraction load served, which should scale similarly to capacity).
37fb8c0493 Merge pull request #418 from NREL/140update
35d00da3c4 Minor changes for ASHRAE 140 test files.
33fd2fd7c1 Moves a bit more code out of measure.rb. Relocates some methods in waterheater.rb so that all apply_foo methods are at the top.
5726bc1c2f Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into wh_refactor
59d4f1dc67 Merge pull request #416 from NREL/os_warnings
a2f4483b57 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into os_warnings
1c5333255f Addresses OpenStudio warnings.
c8d099c3b6 Merge pull request #415 from NREL/cond_bsmt_ceiling
88b0490b77 Update XML.
1286e94758 Remove debug.
c16c70a5df Switch to modifying a single test file.
fc575e7e49 Bugfix for a file w/ a conditioned basement ceiling, where an incorrect outside boundary condition was being set. Added check for warning in eplusout.err file.
5a7db007f2 Fix test.
980678469a Merge pull request #412 from NREL/interior_windows
40d5e7db18 Merge branch 'master' into build-res-hpxml-v3
2a4f0490ef Update test file to include interior window.
e92869ee52 Update docs. [ci skip]
b4293bb648 Fix window height when there are overhangs.
fd543a20f3 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into interior_windows
dd113622e7 Merge pull request #411 from NREL/v010
8a9c510447 Models interior windows as doors to workaround E+ limitations (with the exception of windows on adiabatic surfaces, which are ignored like doors).
0fa44ccbfd Merge pull request #410 from NREL/appliance_error_checking
f4f50cac21 Add a couple examples. [ci skip]
4bf9e8d9e9 Add Scope and Input Defaults sections to the docs. [ci skip]
05663fd1c6 Bump to version 0.10.0.
31bdbf3ca0 Remove constraint.
2eeb432637 Change from an error to a warning based on feedback.
93588ab86f Some cleanup.
8aa07c2e95 Small bugfix to clothes washer NCY for pre-2019A.
94e6feab22 Adds appliance error-checking for negative calculated energy use or hot water use.
464fe564b9 Merge branch 'master' into build-res-hpxml-v3
b443fe771a Oops. Fix XML.
390478c0e1 Merge pull request #409 from NREL/combined_infil_mech_vent
c21c24a319 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into combined_infil_mech_vent
74b6fe9271 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into wh_refactor
2f7dadae9d Removed some unused EnergyManagementSystemGlobalVariables, spotted by Yueyue. Converted two identical local sensors to a global sensor.
c08a46f0b6 Changes how infiltration and mechanical ventilation are combined, per ASHRAE 62.2-2016/19, Appendix C.
e8237c6ff3 remove propane test
362a12b60e Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into wh_refactor
4489df2460 Minor docs update.
7a5a078d31 Misc code cleanup.
64db0c8319 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_sizing_refactor
eccb5e2ded rake, bugfix
f2c8cacb2c merge master into wh_refactor, conflict resolved
a7bb1a7abd Bugfix.
1e0f4efad7 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_sizing_refactor
3afdcfd147 Bugfix.
17be6c444a A little cleanup.
a0d32672d1 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_sizing_refactor
28598d644b Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_sizing_refactor
098daf0309 address some issues
b71acb4951 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_sizing_refactor
e1a1053ccc Bugfix.
243db3c149 Merge branch 'additional_duct_locations' of https://github.com/NREL/OpenStudio-HPXML into hvac_sizing_refactor
3afa3ed905 Merge branch 'additional_duct_locations' of https://github.com/NREL/OpenStudio-HPXML into hvac_sizing_refactor
f2e1df9638 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_sizing_refactor
cfd1e60294 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_sizing_refactor
4d118876d6 Bugfixes.
d8d794cb3c switch to test gpd
56b4c1ca53 Update exterior surface area in compartmentalization_boundary_areas to exclude additional space types. [ci skip]
f0fccf8a14 add appliance tests
49db84d158 A couple bugfixes.
f6fbe79642 Bugfixes.
d384e701f7 Updated schema.
975a268e01 Update sample files.
f843700d06 Address "Very small surface area" warnings in eplusout.err.
e4ff9af09b More cleanup.
04fd84a64e Bugfix and some more progress.
f4efd14e84 Bugfix.
8ba183a1ac First pass.
49fe47b79e bugfix in merging
1877682afe Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into wh_refactor
ee58f671f1 bugfix
41c9415660 some more cleanups
6f3ff88c6c Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into wh_refactor
7b2c972fb4 Merge branch 'wh_refactor' of https://github.com/NREL/OpenStudio-HPXML into wh_refactor
d82f9727e8 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into wh_refactor
e7787f1d9b Removes some code that's no longer needed.
a5d93fed4a more cleanups and unit tests added
9e394e2120 default tank height
4310563b85 hpwh refactor
f4c47191fb bugfix + update_measures
83dae66e23 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into wh_refactor
420119fc9c hot_water_appliance cleanup
12f557a4ca progress
194207127e wh_test added, not completed yet
92eff7a625 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into wh_refactor
1e6f4d2a12 revert test
a20d6d3fc6 wh cleanup

git-subtree-dir: resources/hpxml-measures
git-subtree-split: dc012fbc3b536675bff0963399933c5059cd9bd7
@afontani afontani mentioned this pull request Oct 2, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejhw ejhw ejhw approved these changes

@joseph-robertson joseph-robertson joseph-robertson left review comments

Assignees

@afontani afontani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Geometry Unit Stories SF and Geometry Unit Stories MF are not used
3 participants
@afontani @ejhw @joseph-robertson