-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Geometry Foundation Type to be Based on RECS #492
Conversation
TSV previously based on ORNL's building foundation design handbook published in 1988 and was roughly based on states. New TSV is based on newer data, has climate/moisture zone, and vintage variation.
See assumptions I added above. Would be nice to add these to the tsv files as well.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@ejhw: Not a problem. Addressed |
"A non-trivial percentage of MF units have neither basement, nor slab, nor crawl, which we map to pier and beam (aka open crawlspace). This seems unrealistic, but could represent MF units that are above parking garages or retail space, so we assume it is reasonable to model them as pier and beam open crawlspaces." MF units, or MF buildings? If the former, wouldn't this be more likely to represent MF units above other MF units? With respect to units over parking garages, it might be a good idea to create a new foundation type option for this. You could map it to pier and beam for now, but with the eventual switchover to HPXML, there is an "other non-freezing space" that could be used to represent units over parking garages. As indicated it is modeled as floating with outdoor temperature but with a minimum of 40 deg-F. |
Thanks @shorowit , that's a good question. I had been interpreting the fields for the building containing the household's dwelling unit, but I think you are right that it is for the unit itself. From the codebook:
We don't know the location of the unit in the building, which makes it tough to use these fields for MF. Also slabs wouldn't necessarily be on the ground floor. Once we move to single-unit MF modeling it might become easier to use these fields, but at least for now we still need distributions for foundation types for MF2-4 and MF5+ buildings Options:
So I vote option 1 until we move to single-unit MF modeling and implement unit-specific tsvs. Re: parking garages, unfortunately I think we won't have data to differentiate these from units over other units. Perhaps the future RECS MF survey will help with that. cc @aspeake for awareness |
@afontani I implemented option 1 since the logic was fresh in my mind: https://github.com/NREL/resstock-estimation/pull/63 |
@shorowit do you want a chance to review what I implemented (https://github.com/NREL/resstock-estimation/pull/63)? Are you good with Option 1 above? Thanks again for raising the question. |
@ejhw No, I don't need to review it. I'll defer to your judgment on how you decided to address my comment. |
MF cannot have Pier and Beam and Heated Basement foundations SFA cannot have Pier and Beam foundations
Pull Request Description
This pull request updates the
Geometry Foundation Type.tsv
from the "Building Foundation Design Handbook" published in 1988 to RECS 2009. The new TSV has dependencies on IECC Climate and Moisture regions and Vintage ACS.Companion PRs:
Previous Data Source Documentation
TSV previously based on ORNL's "Building Foundation Design Handbook" published in 1988.
New Data Source
The new data source for
Geometry Building Type.tsv
is RECS 2009. Since the spatial restructure (PR #416), this housing characteristic is a bit out of date because the locations were redefined. As a result, this pull request also fixes the spatial issue created by PR #416.Dependencies:
Assumptions
Updates to Geometry Garage.tsv
Geometry Garage.tsv is updated in the pull request. Now that pier and beam foundations can now be sampled as a foundation type, the
BuildExistingModel
measure does not allow for pier and beam foundations with garages. As a result, a Geometry Foundation Type dependency was added to the Geometry Garage.tsv.A Geometry Foundation Type dependency is added to the
project_testing/Geometry Garage.tsv
.Assumptions:
Checklist
Not all may apply:
project_testing
project_testing
runs without any failuresFor more information on how to perform these checklist items, see the documentation's Advanced Tutorial.