Roofing material restructure #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afontani
approved these changes
Mar 18, 2020
There was a problem hiding this comment.
@joseph-robertson I think it makes sense to split out the housing characteristics. Looks good to me.
Comment on lines
359
to
360
| "weekday_sch": "0.035, 0.033, 0.032, 0.031, 0.032, 0.033, 0.037, 0.042, 0.043, 0.043, 0.043, 0.044, 0.045, 0.045, 0.044, 0.046, 0.048, 0.052, 0.053, 0.05, 0.047, 0.045, 0.04, 0.036", | ||
| "weekend_sch": "0.035, 0.033, 0.032, 0.031, 0.032, 0.033, 0.037, 0.042, 0.043, 0.043, 0.043, 0.044, 0.045, 0.045, 0.044, 0.046, 0.048, 0.052, 0.053, 0.05, 0.047, 0.045, 0.04, 0.036" | ||
| "weekday_sch": "0.046, 0.046, 0.046, 0.046, 0.046, 0.037, 0.035, 0.034, 0.033, 0.028, 0.022, 0.015, 0.012, 0.011, 0.011, 0.012, 0.019, 0.037, 0.049, 0.065, 0.091, 0.105, 0.091, 0.063", | ||
| "weekend_sch": "0.046, 0.046, 0.045, 0.045, 0.046, 0.045, 0.044, 0.041, 0.036, 0.03, 0.024, 0.016, 0.012, 0.011, 0.011, 0.012, 0.019, 0.038, 0.048, 0.06, 0.083, 0.098, 0.085, 0.059" |
There was a problem hiding this comment.
@joseph-robertson Did we miss these *.osw update with the lighting schedule Pull request #419?
Codecov Report
@@ Coverage Diff @@
## master #426 +/- ##
=======================================
Coverage 93.42% 93.42%
=======================================
Files 168 168
Lines 49400 49400
=======================================
+ Hits 46150 46151 +1
+ Misses 3250 3249 -1
Continue to review full report at Codecov.
|
|
@TobiAdekanye Were you able to confirm that this branch works? And is ready to merge? @joseph-robertson Yes, this branch works and is ready to be merged. Thanks! |
afontani
pushed a commit
that referenced
this pull request
Apr 8, 2020
Cherry-pick commit to revert the Insulation Unfinished Attic.tsv to changes made in #426.
9 tasks
afontani
added a commit
that referenced
this pull request
Apr 9, 2020
Bugfix: Revert Insulation Unfinished Attic to #426
joseph-robertson
added a commit
that referenced
this pull request
Jun 26, 2020
947481a7c Merge branch 'master' into build-res-hpxml-v3 a0464a7f1 Merge pull request #424 from NREL/ideal-system 1758bc7ed Clean up some argument descriptions. 092322600 Switch to a single heating system efficiency arg. b1d2db658 Update docs. [ci skip] db048d552 Merge branch 'ideal-system' of https://github.com/NREL/OpenStudio-HPXML into ideal-system 8cc7249f5 resolve report test issue 294bb45b8 Updates for coal fuel type. bfec5cdc9 Found a few more places to use the new hpxml methods. 284a6e25a Merge branch 'master' into build-res-hpxml-v3 650d71d63 update_measures b0dee0c59 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ideal-system ce8f5d66e total check no longer applicable 8e8a864b5 Merge pull request #428 from NREL/skylight-ufactor-fix cb8299a29 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into skylight-ufactor-fix 22425cb7c Merge pull request #431 from NREL/more-fuel-types 3e20fcae8 Rename FuelTypeWood to FuelTypeWoodCord and some small code refactoring in the reporting measure. 949fd9caa ideal system unmet load test not applicable d76ba3d5d report only residual ideal system unmet load 1631ac67e Add energyplus.rb resource w/ a few constants and methods to simplify code. a5fb4c4c2 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ideal-system ac119d2af Prevent coal from being an option for some heating systems in EPvalidator, rather than catching it in hvac.rb. cfcb1644e Oops. ef423877c Merge pull request #429 from NREL/load-warnings 82937fdfb Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into load-warnings 326ddd0a2 Allow additional HPXML fuel types for HVAC systems, water heating systems, and appliances. (Coal and similar fuel types are only allowed for boilers, not other heating system types, due to a limitation in the E+ Coil:Heating:Fuel object.) bc842481a Revert some unexpected changes, and bugfix.. 9b9833a92 bugfix 96564091f Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ideal-system d132da8c9 Update docs and minor updates to defaults. c3d4362f1 Add warnings for plug/fuel loads that are not modeled. f5b85eb49 Merge pull request #427 from NREL/other-heated-space-is-thermal-boundary 2244b940c Converts skylight NFRC U-factor (at 20-degree slope) to SimpleGlazingSystem model input (vertical position). 6ac3f6446 Treat HPXML::LocationOtherHeatedSpace as a conditioned space for HPXML::is_thermal_boundary methods. 96e2a4040 Merge pull request #426 from NREL/eri-end-uses 5fce3a8e3 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ideal-system e5db62006 Exclude unused end uses for ERI outputs. 5391b8814 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ideal-system 77ef1e190 bugfix 863ee94a9 two ideal systems git-subtree-dir: resources/hpxml-measures git-subtree-split: 947481a7c3447c2712015848354ca943b6288b10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Previously, we had:
roofing_materialarguments for both ResidentialConstructionsUnfinishedAttic and ResidentialConstructionsFinishedRoofThe issue with the previous is that if we try to upgrade just
roofing_material, measure ResidentialConstructionsFinishedRoof is applied without all measure arguments specified. By adding the building type dependency to Insulation Unfinished Attic.tsv, Insulation Finished Roof.tsv, and both Roofing Material.tsv files, we can avoid this issue.Other possible solutions are:
Checklist
Not all may apply:
project_testingproject_testingruns without any failuresFor more information on how to perform these checklist items, see the documentation's Advanced Tutorial.