Release 2_2_4 patch #442
Release 2_2_4 patch #442
Conversation
|
@joseph-robertson In addition to
There is also a small fraction of homes with |
|
@aspeake this is a mistake in the logic of the distributions (see #434 ). When we fix that issue so that homes assigned heating fuels are appropriately assigned heating systems, the proposed logic of the |
resources/options_lookup.tsv
Outdated
| HVAC System Heating Fuel Oil Oil Boiler ResidentialHVACBoiler fuel_type=oil "system_type=hot water, forced draft" afue=0.76 oat_reset_enabled=false oat_high=0.0 oat_low=0.0 oat_hwst_high=0.0 oat_hwst_low=0.0 design_temp=180.0 capacity=autosize dse=NA | ||
| ResidentialAirflow has_hvac_flue=true | ||
| HVAC System Heating Fuel Oil Oil Boiler ResidentialHVACBoiler fuel_type=oil "system_type=hot water, forced draft" afue=0.76 oat_reset_enabled=false oat_high=0.0 oat_low=0.0 oat_hwst_high=0.0 oat_hwst_low=0.0 design_temp=180.0 capacity=autosize dse=NA has_hvac_flue=true | ||
| ResidentialAirflow | ||
| ResidentialHVACSizing | ||
| HVAC System Heating Wood None | ||
| HVAC System Heating Wood Wood Stove ResidentialHVACUnitHeater fuel_type=wood efficiency=0.6 fan_power=0 airflow_rate=0 capacity=autosize |
There was a problem hiding this comment.
Move flue argument from airflow to ResidentialHVACUnitHeater?
There was a problem hiding this comment.
...This is meant to reference the HVAC System Heating Wood option
There was a problem hiding this comment.
Oops, missed one. Good catch.
Codecov Report
@@ Coverage Diff @@
## master #442 +/- ##
==========================================
- Coverage 93.40% 93.40% -0.01%
==========================================
Files 169 169
Lines 49389 49381 -8
==========================================
- Hits 46132 46124 -8
Misses 3257 3257
Continue to review full report at Codecov.
|
|
For consistency, the |
33045dedf Update build measure for fixed heater. cb423405e Merge branch 'master' into build-res-hpxml-v3 63a8b426b Merge pull request #444 from NREL/fixed_space_heater 5fdf842b7 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into fixed_space_heater 2a1c35d72 Merge pull request #443 from NREL/fix_tests_on_windows df475efa0 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into fix_tests_on_windows cfd1b0751 Allow FixedHeater (as opposed to PortableHeater) as a HeatingSystemType. 1615cc56a Merge pull request #442 from NREL/adobe_walls f0e45399c Avoid IO.sysopen for capturing stderr, as it results in the file not being closed on Windows, causing errors when running tests. 684c9bc34 Allow Adobe for WallType. 7dad7d574 Merge pull request #440 from NREL/EPvalidator_bugfix 6a53d5a7f Merge branch 'master' into EPvalidator_bugfix f915131fb Merge pull request #438 from NREL/error_output 9b7a1e3bd Fix LightingGroup XPath in EPvalidator.rb 0b5c8ea35 Merge branch 'master' into build-res-hpxml-v3 ba6e64c80 Adds more informative output message if OS measure error or E+ error. b3b3adf0c Merge pull request #437 from NREL/ashrae140_htg_clg 6ba03ab29 Switch to mkdir_p. 5111ab04a More merging of workflow code. d70c63272 Rename argument. a64124869 Switches to TMY3 weather for A140 runs. Merges code from hpxml_translator_test.rb and run_simulation.rb into meta_measure.rb. 25b3ba623 Fix test. 679627944 Retrieve HVAC sizing values before runner is reset. 118afa4f2 Small fix to logging. 6b19cbfda Fix ASHRAE 140 test files to only provide heating or cooling with the ideal air system, not both. git-subtree-dir: resources/hpxml-measures git-subtree-split: 33045dedfba401e669ebc9e80bf671692bcdc1f4
Pull Request Description
Argument
has_hvac_fluefor ResidentialAirflow wasn't being assigned when no heating system was sampled.The proposed solution here is to move the
has_hvac_flueargument from the ResidentialAirflow measure out into the HVAC equipment measures (furnace, boiler, unit heater, shared systems). The value assigned tohas_hvac_fluewill be set as an additional property on the Building model object, and then the airflow measure will parse it from the Building model object. If it doesn't exist, then the value will be set tofalse.Checklist
Not all may apply:
project_testingproject_testingruns without any failuresFor more information on how to perform these checklist items, see the documentation's Advanced Tutorial.