Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResStock-HPXML: Apply tsv files to develop branch #559

Merged
merged 207 commits into from
Jun 29, 2021
Merged

Conversation

joseph-robertson
Copy link
Contributor

@joseph-robertson joseph-robertson commented Mar 23, 2021

Pull Request Description

Companion PR: https://github.com/NREL/resstock-estimation/pull/136

Checklist

Not all may apply:

  • Unit tests have been added or updated
  • All rake tasks have been run, and pass
  • Documentation has been modified appropriately
  • Any new options are added to project_testing
  • project_testing runs without any failures
  • No unexpected regression test changes
  • All tests are passing
  • The changelog has been updated appropriately
  • This branch is up-to-date with develop

For more information on how to perform these checklist items, see the documentation's Advanced Tutorial.

@joseph-robertson joseph-robertson self-assigned this Mar 23, 2021
@joseph-robertson joseph-robertson changed the title Update lookup with options from ResStock-HPXML ResStock-HPXML: Copy tsv files May 17, 2021
Copy link
Contributor

@shorowit shorowit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Assuming the CI comes back with a ✔️, this is ready to go.

@joseph-robertson joseph-robertson marked this pull request as ready for review June 28, 2021 19:13
@joseph-robertson joseph-robertson added this to the ResStock v2.5.0 milestone Jun 28, 2021
@shorowit
Copy link
Contributor

@joseph-robertson Does the changelog need to be updated?

@joseph-robertson
Copy link
Contributor Author

@joseph-robertson Does the changelog need to be updated?

Yes, I suppose so.

@joseph-robertson joseph-robertson merged commit 3c1d732 into develop Jun 29, 2021
@joseph-robertson joseph-robertson deleted the sync-tsvs branch June 29, 2021 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants