-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inverter Temperature Derate based on Pmax ratio #471
Conversation
than inv. efficiency
temp derate test results in pvsamv1
See also NREL/SAM#412 |
shared/lib_shared_inverter.cpp
Outdated
for (size_t i = 0; i < DCStringVoltage.size(); i++) | ||
avgDCVoltage += DCStringVoltage[i]; | ||
avgDCVoltage /= DCStringVoltage.size(); | ||
calculateTempDerate(avgDCVoltage, tempC, powerAC_Watts, power_ratio, tempLoss); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tempLoss will now be in DC. So any comments and the var_info table label should specify that
shared/lib_shared_inverter.cpp
Outdated
} | ||
double power_ratio = 1.0; | ||
if (m_tempEnabled) { | ||
calculateTempDerate(DCStringVoltage, tempC, powerAC_Watts, power_ratio, tempLoss); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this code is now working to potentially clip the input DC power, this should be done before the calls to acpower
.
…to inv_temp_derate_pmax
clipping comparison for thermal derate, updated tests and documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dguittet Need input on how to handle PVYield inverter derate
double startT2 = 0.0; | ||
double Vdc2 = 0.0; | ||
|
||
double p_dc_max = getInverterDCMaxPower(p_dc_rated); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added function to get rated DC power from inverter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks great!
-Changed inverter derate table to be based on ratio of max output power to rated power rather than efficiency
-Update Y-axis label to reflect the ratio rather than the percentage
-Update default inverter temperature derate table to reflect more realistic examples (resource provided by Will Hobbs from Southern Company: https://files.sma.de/downloads/Temp-Derating-TI-en-15.pdf)
-Closes #442