[BUGFIX] Remove dependencies on FLASC temporarily #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issue #32 opened |
genevievestarke
approved these changes
Mar 26, 2024
achenry
pushed a commit
to achenry/wind-hybrid-open-controller
that referenced
this pull request
Apr 22, 2024
* Remove dependencies on FLASC temporarily to allow development to move forward. * Ruff requirements for temporary removal of test.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FLASC is not yet compatible with FLORIS v4. Because the
LookupBasedWakeSteeringControllerdepends on FLASC, a dependency issue arises when trying to use WHOC with Hercules' develop branch.As a temporary fix, this PR removes all FLASC dependencies, disabling the
LookupBasedWakeSteeringControllerin the process.I will create an issue to look for a more permanent solution.