Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Added warning #46

Merged
merged 26 commits into from
May 7, 2016
Merged

ENH: Added warning #46

merged 26 commits into from
May 7, 2016

Conversation

stuwilkins
Copy link
Member

Attn @mpmdean

Warning added, as per #45

@coveralls
Copy link

Coverage Status

Coverage increased (+1.2%) to 29.53% when pulling 5d73354 on stuwilkins:add_warning into 2d4c000 on NSLS-II-CSX:master.

@stuwilkins
Copy link
Member Author

Attn @mpmdean added function to normalize back to what is expected if the stack had no

@coveralls
Copy link

Coverage Status

Coverage increased (+1.3%) to 29.667% when pulling a197f40 on stuwilkins:add_warning into 2d4c000 on NSLS-II-CSX:master.


total_elements = array.size / (array.shape[-1] * array.shape[-2])

if np.sum(Y != total_elements):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be if not norm and np.sum(Y != total_elements): ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes... fixing

@coveralls
Copy link

Coverage Status

Coverage increased (+1.3%) to 29.667% when pulling d5dcccf on stuwilkins:add_warning into 2d4c000 on NSLS-II-CSX:master.

@codecov-io
Copy link

codecov-io commented May 7, 2016

Current coverage is 29.66%

Merging #46 into master will increase coverage by +1.34%

@@           master     #46   diff @@
=====================================
  Files          10      10          
  Lines         293     300     +7   
  Methods         0       0          
  Branches        0       0          
=====================================
+ Hits           83      89     +6   
- Misses        210     211     +1   
  Partials        0       0          

Powered by Codecov. Last updated by 2d4c000...e21761d

@stuwilkins
Copy link
Member Author

@mpmdean I moved this so the stack automatically normalizes for missing data points. Docs are updated.

@stuwilkins stuwilkins merged commit 815519d into NSLS-II-CSX:master May 7, 2016
@stuwilkins stuwilkins deleted the add_warning branch May 7, 2016 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants